Skip to content

fix: correct logical operator in distance comparison and clean up code formatting #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: correct logical operator in distance comparison and clean up code formatting #10

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df4fa2a
fix: correct logical operator in distance comparison and clean up cod…
Deathdadev Jun 1, 2025
6b42be3
Merge branch 'main' of https://github.com/Deathdadev/Direct3D-S2
Deathdadev Jun 1, 2025
2bd8efc
style: adjust indentation for consistency in dot product and updateUD…
Deathdadev Jun 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions third_party/voxelize/src/udf_kernel.cu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,12 +179,12 @@ __device__ void updateUDF(Triangle t, int* udf, const int DIM, const float thres
Point3D queryPoint = {(float)i/(DIM-1) - 0.5, (float)j/(DIM-1) - 0.5, (float)k/(DIM-1) -0.5};
float distance = pointToTriangleDistance(queryPoint, t.v0, t.v1, t.v2);
float distance2 = pointToTriangleDistance(queryPoint, t.v0, t.v1, t.v2, true);
if (distance < threshold / DIM or distance2 < threshold / DIM){
//distance = distance2;
int int_dist = (int)(distance * 10000000);
atomicMin(&udf[idx], int_dist);
}
}
if (distance < threshold / DIM || distance2 < threshold / DIM){
//distance = distance2;
int int_dist = (int)(distance * 10000000);
atomicMin(&udf[idx], int_dist);
}
}

}
}
Expand All @@ -211,4 +211,3 @@ void compute_valid_udf_cuda(float* vertices, int* faces, int* udf, int numTriang
// Launch the kernel
compute_udf_kernel<<<gridSize, blockSize>>>(vertices, faces, udf, numTriangles, DIM, threshold);
}