Take into account discreteness for no cost zero variables in bounds section#2299
Open
MaximSmolskiy wants to merge 1 commit intoERGO-Code:latestfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## latest #2299 +/- ##
=======================================
Coverage 79.20% 79.21%
=======================================
Files 343 343
Lines 83866 83857 -9
=======================================
- Hits 66429 66427 -2
+ Misses 17437 17430 -7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
We've not forgotten about this: just rather busy ATM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that there was inconsistency in https://github.com/ERGO-Code/HiGHS/blob/master/src/io/HMPSIO.cpp#L879 with https://github.com/ERGO-Code/HiGHS/blob/master/src/io/HMPSIO.cpp#L724-L728
As I understand, for example, https://github.com/ERGO-Code/HiGHS/blob/master/src/io/HMPSIO.cpp#L925-L927 - for no cost zero integer variable with
lb = 0andub = +infLI BOUNDwill be written (unlesswrite_no_cost_zero_columns = false) and then maybe it is worth taking this into account innum_no_cost_zero_columns_in_bounds_sectionvariable and corresponding log