Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #2702 +/- ##
=======================================
Coverage 81.29% 81.29%
=======================================
Files 349 349
Lines 85786 85786
=======================================
+ Hits 69736 69738 +2
+ Misses 16050 16048 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
There's a segfault in the unit tests which seems suspicious. |
That test is not compiled with HiPO, so it's a bit weird. |
|
Can we please consider moving to a PR-based workflow over branches? It's hard to tell what people are working on. |
|
I think this is also a good motivation to simplify some of the CI workflows with a build matrix. We shouldn't need to copy-paste code in so many places. (e.g., where I was headed with #2551) |
|
Thanks for the suggestion, but we will retain them for now |
Follow-up to #2699
We need to remove the manually installed versions of metis and gklib in CI to ensure we're actually using the vendored copies.