Modified 1451.lp to test code to permit keywords as constraint names#2812
Merged
Modified 1451.lp to test code to permit keywords as constraint names#2812
1451.lp to test code to permit keywords as constraint names#2812Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## latest #2812 +/- ##
==========================================
- Coverage 80.32% 80.26% -0.07%
==========================================
Files 348 348
Lines 86093 86162 +69
==========================================
- Hits 69157 69154 -3
- Misses 16936 17008 +72 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
To clarify, @khantute, it's the keyword followed by colon that's illegal, not your use of "end" as a constraint name! |
Collaborator
|
I wrote a proper LP parser last year. Some of the grammar can be horrific! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model supplied by @khantute in #1345 failed to load - since it contains a constraint named "end" - which was interpreted as an LP keyword. However, because it's followed by ":", this is illegal in LP files.
Added code to interpret an LP keyword followed by a colon as a constraint name followed by a colon!