Skip to content

Performance when changing LP data#2813

Open
smharwood wants to merge 7 commits intoERGO-Code:latestfrom
smharwood:feature/change-data-performance
Open

Performance when changing LP data#2813
smharwood wants to merge 7 commits intoERGO-Code:latestfrom
smharwood:feature/change-data-performance

Conversation

@smharwood
Copy link

Potential performance improvements when changing LP data (costs, row and column bounds)

In particular, this avoids re-allocating local copies of data and re-sorting index sets

@smharwood smharwood force-pushed the feature/change-data-performance branch from 88ab8c6 to afad16b Compare February 5, 2026 16:21
Copy link
Member

@jajhall jajhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll look at this again, and thanks for submitting the PR, but my instinct is that the overhead you're avoiding doesn't justify the additional code complexity: solving the modified problem is very much more expensive than performing the modification with the local copy

@smharwood
Copy link
Author

Thanks for taking a look - the "repeated sort" is what caught my eye when I was profiling one of my problems.

I'll see if I can come up with an example that I can share that captures the behavior I'm seeing.

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.33%. Comparing base (946a7bb) to head (afad16b).
⚠️ Report is 1 commits behind head on latest.

Additional details and impacted files
@@           Coverage Diff           @@
##           latest    #2813   +/-   ##
=======================================
  Coverage   80.33%   80.33%           
=======================================
  Files         348      348           
  Lines       86084    86109   +25     
=======================================
+ Hits        69152    69175   +23     
- Misses      16932    16934    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants