Add singleton_base #1002
Merged
Add singleton_base #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwellbelove
changed the base branch from
master
to
pull-request/#1002-Add-singleton_base
jwellbelove
merged commit 5e3b029
into
ETLCPP:pull-request/#1002-Add-singleton_base
63 checks passed
jwellbelove
added a commit
that referenced
this pull request
Jan 20, 2025
# Conflicts: # .gitignore # include/etl/file_error_numbers.h
jwellbelove
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current etl::singleton doesn't prevent multiple instances, see also #998
This pull request provides a singleton_base, intended to be used as base class for singletons, as proposed in #998