Fix arm64 signed char #1006
Merged
Fix arm64 signed char #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwellbelove
changed the base branch from
master
to
pull-request/#1006-Fix-arm64-signed-char
jwellbelove
merged commit 7e2aeb9
into
ETLCPP:pull-request/#1006-Fix-arm64-signed-char
63 checks passed
|
I've just noticed that you've changed instances of |
|
Which lines are you referring to for change of I just changed |
|
OK, I'll check tomorrow to see if I made that change myself at some point since the last merge into master. |
jwellbelove
added a commit
that referenced
this pull request
Jan 31, 2025
# Conflicts: # test/test_bit_stream.cpp # test/test_bresenham_line.cpp # test/test_correlation.cpp # test/test_covariance.cpp # test/test_rms.cpp
jwellbelove
pushed a commit
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On arm64, char is unsigned.
That's why etlcpp tests don't compile on arm64, see e.g. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1091157
This pull request fixes the issue by making chars explicitly signed where necessary. Tested on Debian sid arm64.