Skip to content

Comments

refactor: sized_box_for_whitespace linter rule#202

Open
mfederowicz wants to merge 2 commits intoEXERLOG:alphafrom
mfederowicz:sized_box_for_whitespace
Open

refactor: sized_box_for_whitespace linter rule#202
mfederowicz wants to merge 2 commits intoEXERLOG:alphafrom
mfederowicz:sized_box_for_whitespace

Conversation

@mfederowicz
Copy link
Contributor

@mfederowicz mfederowicz commented Oct 1, 2022

Summary

Use SizedBox to add whitespace to a layout.

A Container is a heavier Widget than a SizedBox, and as bonus, SizedBox has a const constructor.

refactor code to pass following linter rules:

  • sized_box_for_whitespace

@mfederowicz mfederowicz requested a review from a team as a code owner October 1, 2022 16:56
…espace

# Conflicts:
#	lib/UI/exercise/exercise_card.dart
#	lib/UI/exercise/set_widget.dart
#	lib/UI/prev_workout/prev_exercise_card.dart
#	lib/UI/prev_workout/prev_set_widget.dart
#	lib/UI/workout/redo_workout_alert.dart
#	lib/src/feature/authentication/view/landing_screen.dart
@stale
Copy link

stale bot commented Oct 18, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the stale label Oct 18, 2022
@stale stale bot closed this Oct 25, 2022
@mfederowicz
Copy link
Contributor Author

ping

@tenshiAMD tenshiAMD reopened this Oct 28, 2022
@stale stale bot removed the stale label Oct 28, 2022
@mfederowicz
Copy link
Contributor Author

@tenshiAMD if this PR is approved, can you merge it to alpha?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants