#446 - Enhance tab management and global hotkeys functionality #487
+457
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoulKa
reviewed
Aug 11, 2025
Comment on lines
20
to
23
| const selectedRequestId = useCollectionStore((state) => state.selectedRequestId); | ||
| const collection = useCollectionStore((state) => state.collection); | ||
| const currentRequest = useCollectionStore(selectRequest); | ||
| const folders = useCollectionStore((state) => state.folders); |
There was a problem hiding this comment.
this seems quite inefficient as it would trigger a rerender every time anything changes. However, we only need the information once a hotkey was triggered. You can instead use useCollectionStore.state I think. This is the getter that does not trigger a rerender.
| if (child.type === 'request') { | ||
| result.push(child.id); | ||
| } else if (child.type === 'folder') { | ||
| result.push(...getAllRequestsInOrder(child.children || [])); |
There was a problem hiding this comment.
what's with children of children? This for loop only goes one level deep
giemic8
force-pushed
the
feature/446-add-hotkey-actions
branch
from
f6f3f37 to
9f6eec4
Compare
giemic8
force-pushed
the
feature/446-add-hotkey-actions
branch
from
62c73f8 to
84d47dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Automatically opens parent folders when navigating to nested requests
Hotkeys are disabled when typing in input fields to prevent conflicts
Created
useGlobalHotkeyshook with configurable callback propsEnsured hotkeys work globally across the application while respecting user input contexts
Closed #446
Testing
On Mac
Checklist