Skip to content

Conversation

@rickard-von-essen
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.76%. Comparing base (38489a5) to head (95bdc2e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
+ Coverage   44.39%   44.76%   +0.36%     
==========================================
  Files         108      106       -2     
  Lines       12669     9326    -3343     
  Branches      593      556      -37     
==========================================
- Hits         5625     4175    -1450     
+ Misses       7036     5145    -1891     
+ Partials        8        6       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@raphaelcoeffic
Copy link
Member

raphaelcoeffic commented May 29, 2025

@rickard-von-essen it seems the code coverage for web worker breaks with vitest v3. Can you please have a look?

You can see that this PR changes the code coverage numbers, whereby it shouldn't actually. What happens here is that the web worker is excluded from the total, thus increasing the ratio tested/untested.

@rickard-von-essen
Copy link
Contributor Author

Didn't notice that. I'll have a look in few days.

@rickard-von-essen
Copy link
Contributor Author

Failed to convert coverage for file:///Users/ext.rickard.von/src/edgetx-buddy/src/webworker/backend.worker.ts.
 TypeError: Cannot read properties of undefined (reading 'endCol')
    at range.sliceRange (file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:554:55)
    at CovSource.offsetToOriginalRelative (file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:1985:20)
    at V8ToIstanbul._maybeRemapStartColEndCol (file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:2394:93)
    at file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:2303:61
    at Array.forEach (<anonymous>)
    at file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:2301:21
    at Array.forEach (<anonymous>)
    at V8ToIstanbul.applyCoverage (file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:2300:13)
    at file:///Users/ext.rickard.von/src/edgetx-buddy/node_modules/@vitest/coverage-v8/dist/provider.js:2762:16
    at async Promise.all (index 9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants