Skip to content

chore(cpn): move wizard to subdir #6564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

chore(cpn): move wizard to subdir #6564

merged 1 commit into from
Sep 1, 2025

Conversation

@ikkemaniac
Copy link
Contributor

@ikkemaniac ikkemaniac commented Aug 31, 2025

move wizard to subdir per @elecpower request in #6556

@pfeerick pfeerick added this to the 3.0 milestone Sep 1, 2025
@pfeerick pfeerick added the house keeping 🧹 Cleanup of code and house keeping label Sep 1, 2025
pfeerick
pfeerick approved these changes Sep 1, 2025
View reviewed changes
Copy link
Member

@pfeerick pfeerick left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple, self-contained, and compiles... LGTM! Companion is Neil's domain so I'll let him have the last word ;)

@pfeerick pfeerick requested a review from elecpower September 1, 2025 00:25
elecpower
elecpower approved these changes Sep 1, 2025
View reviewed changes
Copy link
Collaborator

@elecpower elecpower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@pfeerick pfeerick merged commit 7230b26 into EdgeTX:main Sep 1, 2025
3 checks passed
@ikkemaniac ikkemaniac deleted the clean-wizard branch September 1, 2025 20:05
@ikkemaniac
Copy link
Contributor Author

ikkemaniac commented Sep 1, 2025

i just now realized i didn't run update-companion-translations.sh. It seems to update quite a bit + some changes that have nothing to do with this PR. Should the result of update-companion-translations.sh be included (should i create a PR for that?)?

@pfeerick
Copy link
Member

pfeerick commented Sep 1, 2025

companion_translations job probably hasn't been run for about two months, so no real surprise there. I'll probably run in the next few days after #6521 is in, or even as the last step before merging that. 🤷 Thanks for the reminder 🤭

@ikkemaniac
Copy link
Contributor Author

ikkemaniac commented Sep 2, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfeerick pfeerick pfeerick approved these changes

@elecpower elecpower elecpower approved these changes

Assignees

No one assigned

Labels

house keeping 🧹 Cleanup of code and house keeping

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ikkemaniac @pfeerick @elecpower