Skip to content

Conversation

tomqin93
Copy link
Contributor

What type of PR is this?

/kind documentation

What this PR does / why we need it:

This PR adds comprehensive documentation for Shifu's metrics authentication and authorization system. The documentation covers:

  • Introduction to authentication and authorization features in Kubebuilder v4
  • Default HTTP configuration (port 8080) and why HTTP is used by default
  • How authentication works using TokenReview and SubjectAccessReview
  • Step-by-step guide for granting metrics access to ServiceAccounts
  • Optional HTTPS setup with cert-manager for production environments
  • Troubleshooting common issues (Unauthorized, Forbidden, x509 errors, etc.)
  • Complete example showing Prometheus integration with proper RBAC

This documentation helps users understand how to securely access metrics from Shifu's controller and configure their monitoring tools (like Prometheus) to scrape metrics with proper authentication.

Which issue(s) this PR fixes:

Fixes #

How is this PR tested:

  • other (documentation review)

Special notes for your reviewer:

The documentation follows the existing structure and style of Shifu docs. It includes practical examples and troubleshooting guidance based on common scenarios users encounter when setting up metrics collection.

Does this PR introduce a user-facing change?

Add comprehensive documentation for metrics authentication and authorization, including HTTP/HTTPS configuration, RBAC setup, and Prometheus integration examples.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

- [Docs]: docs/references/advanced-features/metrics-authentication.md

This commit adds detailed documentation covering Shifu's metrics authentication
and authorization system, including:

- Introduction to authentication and authorization features
- Default HTTP configuration and rationale
- Step-by-step guide for granting metrics access
- Optional HTTPS setup with cert-manager
- Troubleshooting common issues
- Complete Prometheus integration example

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@Copilot Copilot AI review requested due to automatic review settings September 30, 2025 18:43
@tomqin93 tomqin93 requested a review from saiyan86 as a code owner September 30, 2025 18:43
Copy link

vercel bot commented Sep 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
shifu-dev Ready Ready Preview Comment Oct 1, 2025 7:09am

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive documentation for Shifu's metrics authentication and authorization system introduced in Kubebuilder v4. The documentation provides detailed guidance on securing metrics access through RBAC and configuring monitoring tools like Prometheus.

Key changes include:

  • Introduction of authentication/authorization concepts and default HTTP configuration
  • Step-by-step RBAC setup instructions for granting metrics access to ServiceAccounts
  • Optional HTTPS configuration with cert-manager for production environments

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

This commit adds the Chinese (Simplified) translation of the metrics
authentication documentation to support bilingual documentation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants