Skip to content

Use Sentry with SPM #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
noahsmartin wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Use Sentry with SPM #669

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 10 additions & 18 deletions ios/HackerNews.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,7 @@
A4BED5C42AD5E083001642B3 /* (null) in Frameworks */ = {isa = PBXBuildFile; };
A4D28AEE2C237E2A007F20D0 /* SnapshotPreferences in Frameworks */ = {isa = PBXBuildFile; productRef = A4D28AED2C237E2A007F20D0 /* SnapshotPreferences */; };
A4D28AF02C237E2A007F20D0 /* SnapshottingTests in Frameworks */ = {isa = PBXBuildFile; productRef = A4D28AEF2C237E2A007F20D0 /* SnapshottingTests */; };
A9DF68FF511E48048B0A703D /* Sentry in Frameworks */ = {isa = PBXBuildFile; productRef = 673236B0A4D04137A0D80A76 /* Sentry */; };
C3AC6AD92CB6E8F7006BD22D /* SnapshottingTests in Frameworks */ = {isa = PBXBuildFile; productRef = C3AC6AD82CB6E8F7006BD22D /* SnapshottingTests */; };
F40E42A02EA80E1600E53876 /* SentrySwiftUI in Frameworks */ = {isa = PBXBuildFile; productRef = F40E429F2EA80E1600E53876 /* SentrySwiftUI */; };
F45F6EA52D4D1E50003FA9A3 /* Common in Frameworks */ = {isa = PBXBuildFile; productRef = F45F6EA42D4D1E50003FA9A3 /* Common */; };
F45F6EA72D4D1E57003FA9A3 /* Common in Frameworks */ = {isa = PBXBuildFile; productRef = F45F6EA62D4D1E57003FA9A3 /* Common */; };
F45F6F4A2D4D2185003FA9A3 /* Common in Embed Frameworks */ = {isa = PBXBuildFile; productRef = F45F6EA42D4D1E50003FA9A3 /* Common */; settings = {ATTRIBUTES = (CodeSignOnCopy, ); }; };
Expand All @@ -37,6 +35,7 @@
FA3637612EC7AC7D00541313 /* AccessibilitySnapshotCore in Frameworks */ = {isa = PBXBuildFile; productRef = FA3637602EC7AC7D00541313 /* AccessibilitySnapshotCore */; };
FA3637642EC7ACAD00541313 /* AccessibilitySnapshotCore in Frameworks */ = {isa = PBXBuildFile; productRef = FA3637632EC7ACAD00541313 /* AccessibilitySnapshotCore */; };
FA80C2702EC78D7500A700AB /* AccessibilitySnapshotCore in Frameworks */ = {isa = PBXBuildFile; productRef = FA80C26F2EC78D7500A700AB /* AccessibilitySnapshotCore */; };
FA914E352ECE6A4700C54BDD /* SentrySPM in Frameworks */ = {isa = PBXBuildFile; productRef = FA914E342ECE6A4700C54BDD /* SentrySPM */; };
/* End PBXBuildFile section */

/* Begin PBXContainerItemProxy section */
Expand Down Expand Up @@ -193,12 +192,11 @@
files = (
F45F6EA52D4D1E50003FA9A3 /* Common in Frameworks */,
A47309B42AA29D9600201376 /* SwiftSoup in Frameworks */,
FA914E352ECE6A4700C54BDD /* SentrySPM in Frameworks */,
F48E9ECB2D4D691600FD8B30 /* ETDistribution in Frameworks */,
A4D28AEE2C237E2A007F20D0 /* SnapshotPreferences in Frameworks */,
F45F703E2D4D2695003FA9A3 /* Fonts in Frameworks */,
F40E42A02EA80E1600E53876 /* SentrySwiftUI in Frameworks */,
A495B2952BFEA11B00A8A8A9 /* Reaper in Frameworks */,
A9DF68FF511E48048B0A703D /* Sentry in Frameworks */,
);
runOnlyForDeploymentPostprocessing = 0;
};
Expand Down Expand Up @@ -372,13 +370,12 @@
name = HackerNews;
packageProductDependencies = (
A47309B32AA29D9600201376 /* SwiftSoup */,
673236B0A4D04137A0D80A76 /* Sentry */,
A495B2942BFEA11B00A8A8A9 /* Reaper */,
A4D28AED2C237E2A007F20D0 /* SnapshotPreferences */,
F45F6EA42D4D1E50003FA9A3 /* Common */,
F45F703D2D4D2695003FA9A3 /* Fonts */,
F48E9ECA2D4D691600FD8B30 /* ETDistribution */,
F40E429F2EA80E1600E53876 /* SentrySwiftUI */,
FA914E342ECE6A4700C54BDD /* SentrySPM */,
);
productName = HackerNews;
productReference = A42705792A4293B10057E439 /* HackerNews.app */;
Expand Down Expand Up @@ -1231,8 +1228,8 @@
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/getsentry/sentry-cocoa/";
requirement = {
kind = exactVersion;
version = "9.0.0-alpha.1";
branch = autoTrackAppLaunch;
kind = branch;
};
};
A42271692DE78DEF002F03D5 /* XCRemoteSwiftPackageReference "faultordering" */ = {
Expand Down Expand Up @@ -1302,11 +1299,6 @@
/* End XCRemoteSwiftPackageReference section */

/* Begin XCSwiftPackageProductDependency section */
673236B0A4D04137A0D80A76 /* Sentry */ = {
isa = XCSwiftPackageProductDependency;
package = 995A2BEDEF224F7085D3DB13 /* XCRemoteSwiftPackageReference "sentry-cocoa" */;
productName = Sentry;
};
A422716A2DE78DEF002F03D5 /* FaultOrdering */ = {
isa = XCSwiftPackageProductDependency;
package = A42271692DE78DEF002F03D5 /* XCRemoteSwiftPackageReference "faultordering" */;
Expand Down Expand Up @@ -1347,11 +1339,6 @@
package = A4D28AEC2C237E2A007F20D0 /* XCRemoteSwiftPackageReference "SnapshotPreviews" */;
productName = SnapshottingTests;
};
F40E429F2EA80E1600E53876 /* SentrySwiftUI */ = {
isa = XCSwiftPackageProductDependency;
package = 995A2BEDEF224F7085D3DB13 /* XCRemoteSwiftPackageReference "sentry-cocoa" */;
productName = SentrySwiftUI;
};
F45F6EA42D4D1E50003FA9A3 /* Common */ = {
isa = XCSwiftPackageProductDependency;
package = F45F6E532D4D1D3E003FA9A3 /* XCLocalSwiftPackageReference "Packages/Common" */;
Expand Down Expand Up @@ -1401,6 +1388,11 @@
package = FA80C26E2EC78D7500A700AB /* XCRemoteSwiftPackageReference "AccessibilitySnapshot" */;
productName = AccessibilitySnapshotCore;
};
FA914E342ECE6A4700C54BDD /* SentrySPM */ = {
isa = XCSwiftPackageProductDependency;
package = 995A2BEDEF224F7085D3DB13 /* XCRemoteSwiftPackageReference "sentry-cocoa" */;
productName = SentrySPM;
};
/* End XCSwiftPackageProductDependency section */
};
rootObject = A42705712A4293B10057E439 /* Project object */;
Expand Down
12 changes: 6 additions & 6 deletions ios/HackerNews.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 0 additions & 2 deletions ios/HackerNews/Bookmarks/BookmarksScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

import Foundation
import SwiftUI
import SentrySwiftUI

struct BookmarksScreen: View {
@Binding var model: AppViewModel
Expand Down Expand Up @@ -53,7 +52,6 @@ struct BookmarksScreen: View {
}
.frame(height: 60)
}
.sentryTrace("BookmarksScreen")
}
}

Expand Down
3 changes: 0 additions & 3 deletions ios/HackerNews/Feed/FeedScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import Foundation
import SwiftUI
import Common
import SentrySwiftUI

struct FeedScreen: View {

Expand Down Expand Up @@ -64,7 +63,6 @@ struct FeedScreen: View {
}
}
.tabViewStyle(.page(indexDisplayMode: .never))
.sentryTrace("FeedScreen")
}
}
}
Expand Down Expand Up @@ -127,7 +125,6 @@ private struct FeedListView: View {
try? await Task.sleep(for: .milliseconds(300))
await model.fetchInitialPosts(feedType: model.feedState.selectedFeed)
}
.sentryTrace("FeedListView")
}
}

Expand Down
2 changes: 1 addition & 1 deletion ios/HackerNews/HNApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//

import Reaper
import Sentry
import SentrySwift
import SwiftData
import SwiftUI
import Common
Expand Down
2 changes: 1 addition & 1 deletion ios/HackerNews/Settings/SendFeedbackScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
// Created by Trevor Elkins on 4/16/25.
//

import Sentry
import SentrySwift
import SwiftUI

struct SendFeedbackScreen: View {
Expand Down
2 changes: 0 additions & 2 deletions ios/HackerNews/Settings/SettingsScreen.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import Foundation
import SwiftUI
import Common
import SentrySwiftUI

struct SettingsScreen: View {
@Binding var model: AppViewModel
Expand Down Expand Up @@ -270,7 +269,6 @@ struct SettingsScreen: View {
.sheet(isPresented: $isShowingFeedback) {
SendFeedbackScreen()
}
.sentryTrace("SettingsScreen")
}
}

Expand Down
2 changes: 1 addition & 1 deletion ios/HackerNews/Utils/Assert.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
//

import Foundation
import Sentry
import SentrySwift

/// Fails fast in Debug, logs to Sentry in Release.
/// - Parameters:
Expand Down
2 changes: 1 addition & 1 deletion ios/HackerNews/Utils/Logger.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import Sentry
import SentrySwift

struct Logger {
static func info(_ message: String) {
Expand Down
Loading