Allow bibliography path and link URL to be configured#23
Open
olvidalo wants to merge 1 commit intoEpiDoc:masterfrom
Open
Allow bibliography path and link URL to be configured#23olvidalo wants to merge 1 commit intoEpiDoc:masterfrom
olvidalo wants to merge 1 commit intoEpiDoc:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
t:ptr[@target]template inhtm-teibibl.xslhardcodes two EFES specific values:webapps/ROOT/content/xml/authority/bibliography.xmlrelative tosystem-property('user.dir')provided by the Java runtime through EFES/Cocoon../concordance/bibliography/{id}.html).This makes it hard to use the stylesheets outside of EFES, or with different output site structures that don't follow EFES' patterns.
This PRs uses two configurable params following existing conventions to solve this:
htm-teibibltemplate now uses$localbiblto construct the path to the bibliography fileglobal-varsandparams.xml,$localbiblis set to the currently hardcoded default path via the new$default-biblocvariable, ensuring full backwards compatibility without breaking existing projects$bib-link-templateparam can be used to provide an URL template where$1is replaced by the bibliography entry ID. Defaults to current pattern../concordance/bibliography/$1.htmlfor backwards compatibility.It would be great if this could be considered for merging as one step to make the stylesheets more independent from EFES.