Fix Mixed Content warning for external resources#57
Open
phit wants to merge 2 commits intoEthanWaite:masterfrom
Open
Fix Mixed Content warning for external resources#57phit wants to merge 2 commits intoEthanWaite:masterfrom
phit wants to merge 2 commits intoEthanWaite:masterfrom
Conversation
|
This is only used for https? I recommends using // (double slash) for http and https. |
Author
|
there's no reason to ever request over http when https is available see the big yellow box here https://www.paulirish.com/2010/the-protocol-relative-url/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proxying this through Nginx and got some mixed content warnings. This fixes it, not sure if this project is still active.
Either way you can easily do this by manually editing the release jar, just leaving it here for anyone that may find it useful in the future.