-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Fix/65244 - [App] Paste the copied message having quote markdown displays wrong line with original #66775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/65244 - [App] Paste the copied message having quote markdown displays wrong line with original #66775
Conversation
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
|
|
Please hold on #66685 as we're also updating |
|
@eVoloshchak #66685 has been merged into main. Looks like we need to create a PR to fix the typecheck from |
@eVoloshchak I'm always up for it. But I mean from version 2.0.148 there will be a typescript error by |
Someone else will do it, it should be fixed as part of the issue that introduced it. I have to report it if it isn't being fixed, is there any additional info you have? How did you confirm this was caused by 2.0.148? |
It comes from this PR |
|
How did you confirm that? Could you link the failed GH check here please? Or did you run it locally? |
You mean this?
I also run it locally and it gives typescript check error. |
|
@eVoloshchak Fixing this TypeScript error is quite simple. If possible, I think we can handle it ourselves. |
|
@dmkt9, that would be the best approach, thank you! |
@eVoloshchak I just opened a PR here. |
d7f727b to
e0c028f
Compare
|
@eVoloshchak This PR is ready! |
Co-authored-by: Eugene Voloshchak <[email protected]>
|
@eVoloshchak I have just changed it. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-08-14.at.16.54.38.movAndroid: mWeb ChromeScreen.Recording.2025-08-14.at.16.42.36.moviOS: HybridAppScreen.Recording.2025-08-14.at.16.37.40.moviOS: mWeb SafariScreen.Recording.2025-08-14.at.16.38.19.movMacOS: Chrome / SafariScreen.Recording.2025-08-14.at.16.35.54.movMacOS: DesktopScreen.Recording.2025-08-14.at.16.57.31.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@iwiznia Could you please take a look when you get a chance? Thank you! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.1.96-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.96-2 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.96-2 🚀
|
Explanation of Change
Update
expensify-commonto complete the fix.The PR of
expensify-commonhereFixed Issues
$ #65244
PROPOSAL: #65244 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mp4
Android: mWeb Chrome
android.mweb.mp4
iOS: Native
ios.native.mp4
iOS: mWeb Safari
ios.mweb.mp4
MacOS: Chrome / Safari
mac.safari.mp4
MacOS: Desktop
mac.desktop.mp4