Skip to content

Convert fastMerge to worklet to be able to use it in animations on NewDot #855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

Convert fastMerge to worklet to be able to use it in animations on NewDot #855

merged 2 commits into from
May 27, 2025

Conversation

@parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented May 27, 2025

Fixed Issues

$ Expensify/App#62862

Tests

  1. What unit/integration tests cover your change? What autoQA tests cover your change?
  2. What tests did you perform that validates your changed worked?

QA

  1. What does QA need to do to validate your changes?
  2. What areas to they need to test for regressions?

@parasharrajat parasharrajat requested a review from a team as a code owner May 27, 2025 17:08
@melvin-bot melvin-bot bot requested review from MonilBhavsar and removed request for a team May 27, 2025 17:09
@parasharrajat
Copy link
Member Author

parasharrajat commented May 27, 2025

We can use the top-level worklet; when all the functions are in same file. Source https://expensify.slack.com/archives/C05LX9D6E07/p1748363139288069?thread_ts=1748347517.737619&cid=C05LX9D6E07

@JS00001 JS00001 requested review from JS00001 and removed request for MonilBhavsar May 27, 2025 17:17
@JS00001 JS00001 merged commit 88bbe74 into Expensify:main May 27, 2025
6 checks passed
@os-botify
Copy link
Contributor

os-botify bot commented May 27, 2025

🚀 Published to npm in 2.0.137 🎉

@parasharrajat parasharrajat changed the title Convert fastmerge to worklet to be able to use it in animations on NewDot Convert fastMerge to worklet to be able to use it in animations on NewDot May 27, 2025
@Skalakid Skalakid mentioned this pull request Jul 9, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JS00001 JS00001 JS00001 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parasharrajat @JS00001