Various TLC by jorgensd · Pull Request #824 · FEniCS/ffcx

jorgensd · 2026-03-09T07:56:27Z

Requires FEniCS/ufl#469.

Documentation, typing and some logical simplification/modularization in the IR and table generation.

ffcx/codegeneration/integral_generator.py

ffcx/ir/analysis/modified_terminals.py

ffcx/ir/elementtables.py

ffcx/ir/integral.py

ffcx/definitions.py

ffcx/codegeneration/integral_generator.py

coveralls · 2026-03-09T11:00:32Z

coverage: 84.659% (+0.08%) from 84.581%
when pulling d51bd8f on dokken/ffcx-representation-tlc
into 9c7923b on main.

.github/workflows/dolfinx-tests.yml

.github/workflows/pythonapp.yml

ffcx/codegeneration/integral_generator.py

schnellerhase · 2026-03-18T15:28:57Z

ffcx/ir/elementtables.py


 def is_permuted_table(table, rtol=default_rtol, atol=default_atol):
    """Check if table is permuted."""
+    # NOTE: Could be done faster with numpy broadcasting, i.e.


create issue to track.

Not sure. it kind of hurts readability to change. I could remove the comment?

ffcx/ir/representation.py

Co-authored-by: Paul T. Kühner <56360279+schnellerhase@users.noreply.github.com>

jorgensd added 3 commits March 5, 2026 12:14

Another attempt at cell averagig. Requires minor changes to ufl

b1b0d39

Various typing

64bc154

Refactor representation to be more modular and documented

0a2099d

jorgensd requested review from michalhabera and schnellerhase March 9, 2026 07:56

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/codegeneration/integral_generator.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/ir/analysis/modified_terminals.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/ir/analysis/modified_terminals.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/ir/analysis/modified_terminals.py Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/ir/elementtables.py Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/ir/elementtables.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/ir/integral.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/ir/integral.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/ir/integral.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/ir/integral.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/ir/integral.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/definitions.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/definitions.py Outdated Show resolved Hide resolved

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/definitions.py Outdated Show resolved Hide resolved

jorgensd added 5 commits March 9, 2026 09:07

Remove cell_avg changes

5d03cf6

Further removal

2dac1f9

Further reversal

6657f13

Further reversals

704010e

Merge branch 'main' into dokken/ffcx-representation-tlc

406a186

jorgensd requested a review from IgorBaratta March 9, 2026 10:46

jorgensd marked this pull request as ready for review March 9, 2026 10:46

jorgensd added 2 commits March 9, 2026 10:47

Further tlc

6153504

Use custom ufl branch

de83214

jorgensd requested a review from mscroggs March 9, 2026 10:53

jorgensd added the housekeeping label Mar 9, 2026

jorgensd commented Mar 9, 2026

View reviewed changes

ffcx/codegeneration/integral_generator.py Outdated Show resolved Hide resolved

Apply suggestions from code review

373ddec

jorgensd commented Mar 10, 2026

View reviewed changes

.github/workflows/dolfinx-tests.yml Outdated Show resolved Hide resolved

jorgensd commented Mar 10, 2026

View reviewed changes

.github/workflows/pythonapp.yml Outdated Show resolved Hide resolved

jorgensd commented Mar 10, 2026

View reviewed changes

.github/workflows/pythonapp.yml Outdated Show resolved Hide resolved

Reset ufl branches

cbd5b76

schnellerhase reviewed Mar 18, 2026

View reviewed changes

ffcx/codegeneration/integral_generator.py Show resolved Hide resolved

schnellerhase reviewed Mar 18, 2026

View reviewed changes

ffcx/ir/representation.py Outdated Show resolved Hide resolved

schnellerhase reviewed Mar 18, 2026

View reviewed changes

ffcx/ir/representation.py Outdated Show resolved Hide resolved

schnellerhase approved these changes Mar 18, 2026

View reviewed changes

Apply suggestions from code review

d51bd8f

Co-authored-by: Paul T. Kühner <56360279+schnellerhase@users.noreply.github.com>

Uh oh!

Conversation

jorgensd commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

schnellerhase Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

jorgensd Mar 19, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jorgensd commented Mar 9, 2026 •

edited

Loading

coveralls commented Mar 9, 2026 •

edited

Loading