Skip to content

Making provider name optional #2223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: update dev/0.7.0 to charlie dev branch
merged 3 commits into from
Sep 12, 2024
Merged

Making provider name optional #2223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17dd2b7
Stringify name
alaydshah Sep 12, 2024
4a198eb
Set name arg required to True
alaydshah Sep 12, 2024
16417d5
Making name optional
alaydshah Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/fedml/api/modules/device.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def _bind(
"-pph",
str(price_per_hour),
"-n",
name
str(name)
]
).pid
sys_utils.save_login_process(ClientConstants.LOCAL_HOME_RUNNER_DIR_NAME,
Expand Down
5 changes: 2 additions & 3 deletions python/fedml/computing/scheduler/slave/client_daemon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@

import fedml
from fedml.computing.scheduler.comm_utils.sys_utils import cleanup_all_fedml_client_api_processes, \
cleanup_all_fedml_client_learning_processes, cleanup_all_fedml_client_login_processes, get_python_program, \
daemon_ota_upgrade
cleanup_all_fedml_client_learning_processes, cleanup_all_fedml_client_login_processes, get_python_program
from fedml.computing.scheduler.scheduler_core.general_constants import MarketplaceType
from fedml.computing.scheduler.slave.client_constants import ClientConstants
from fedml.computing.scheduler.comm_utils.run_process_utils import RunProcessUtils
Expand All @@ -27,7 +26,7 @@
parser.add_argument("--local_on_premise_platform_port", "-lpp", type=int, default=80)
parser.add_argument("--marketplace_type", "-mpt", type=str, default=MarketplaceType.SECURE.name)
parser.add_argument("--price_per_hour", "-pph", type=str, default="0.0")
parser.add_argument("--name", "-n", type=str, default="")
parser.add_argument("--name", "-n", type=str, nargs='?', default="")

args = parser.parse_args()
args.user = args.user
Expand Down
2 changes: 1 addition & 1 deletion python/fedml/computing/scheduler/slave/client_login.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def logout():
parser.add_argument("--local_on_premise_platform_port", "-lpp", type=int, default=80)
parser.add_argument("--marketplace_type", "-mpt", type=str, default=MarketplaceType.SECURE.name)
parser.add_argument("--price_per_hour", "-pph", type=str, default="0.0")
parser.add_argument("--name", "-n", type=str, default="")
parser.add_argument("--name", "-n", type=str, nargs='?', default="")

args = parser.parse_args()
args.user = args.user
Expand Down
Loading