[backend/frontend] feat(integrations): add ability to update multiple images, demo and datasheet url (#1404) (#1837) by Kroustille · Pull Request #1826 · FiligranHQ/xtm-hub

Kroustille · 2026-03-05T07:54:00Z

Context

Briefly describe the purpose and context of this PR. Include relevant screenshots or screen recordings for the product team.

This PR extends the integration and connector service forms to support updating multiple images, and adds datasheet_url and demo_url fields to all integration types. It refactors shared form field logic into a centralized useServiceFormFields hook (renamed from useSimpleServiceFormField), adds a new ConnectorForm for editing connectors, introduces the DocumentSourceType enum to distinguish internal vs. external images, and adds a carousel to connector slug views.

Changes:

Added datasheet_url and demo_url fields across all integration types (schema, resolvers, metadata, forms, detail views, i18n)
Refactored image handling to differentiate between internal and external source types, including a migration to mark existing connector images as external
Created a ConnectorForm component and enabled connector editing/updating in the UI, previously restricted

How to test

Provide step-by-step instructions to test your changes. Include screenshots of your local testing results.

Related issues

Checklist

Quality

I consider this work complete and ready for review
I tested all features and edge cases
I refactored code where necessary to improve quality
I made sure my code meets development guidelines
I performed a self-review of my code

Testing

I wrote test cases for the relevant use cases (unit, integration or e2e tests)
(Bug fixes only) I added tests that reproduce and verify the fix

What tests have been made

Unit tests
Integration tests
E2E tests
Local manual tests

Additional information

Any additional context, dependencies, or concerns reviewers should know about.

codecov · 2026-03-05T08:01:37Z

Codecov Report

❌ Patch coverage is 27.14808% with 797 lines in your changes missing coverage. Please review.
✅ Project coverage is 35.86%. Comparing base (c0127d5) to head (31e1556).
⚠️ Report is 2 commits behind head on development.

Files with missing lines	Patch %	Lines
...ents/service/integrations/forms/connector-form.tsx	0.00%	155 Missing and 1 partial ⚠️
...omponents/service/form/use-service-form-fields.tsx	0.00%	131 Missing ⚠️
...l-front/src/components/service/form/logo-field.tsx	0.00%	79 Missing and 1 partial ⚠️
...nts/service/document/shareable-resouce-details.tsx	0.00%	38 Missing ⚠️
...omponents/service/document/use-document-context.ts	0.00%	38 Missing ⚠️
...nents/service/integrations/forms/csv-feed-form.tsx	0.00%	38 Missing ⚠️
...ponents/service/integrations/forms/stream-form.tsx	0.00%	37 Missing ⚠️
...nts/service/integrations/forms/taxii-feed-form.tsx	0.00%	37 Missing ⚠️
...ntegrations/forms/third-party-integration-form.tsx	0.00%	35 Missing ⚠️
...rios/[serviceInstanceId]/openaev-scenario-form.tsx	0.00%	31 Missing ⚠️
... and 30 more

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #1826      +/-   ##
===============================================
+ Coverage        35.68%   35.86%   +0.18%     
===============================================
  Files              654      658       +4     
  Lines            41432    41912     +480     
  Branches          2395     2439      +44     
===============================================
+ Hits             14785    15032     +247     
- Misses           26399    26631     +232     
- Partials           248      249       +1

Files with missing lines	Coverage Δ
.../modules/ingest-manifest/ingest-manifest.domain.ts	`91.17% <100.00%> (ø)`
.../modules/ingest-manifest/ingest-manifest.helper.ts	`89.23% <100.00%> (ø)`
...pi/src/modules/services/document/document.model.ts	`100.00% <100.00%> (ø)`
...rvices/document/domain/document.children.domain.ts	`93.50% <100.00%> (+10.69%)`	⬆️
...ocument/opencti/integrations/integrations.model.ts	`100.00% <100.00%> (ø)`
apps/portal-api/src/utils/error/error.code.ts	`100.00% <100.00%> (ø)`
.../service/components/subscribable-services.types.ts	`100.00% <ø> (ø)`
...rc/components/service/document/document.graphql.ts	`0.00% <ø> (ø)`
...onents/service/document/public-document.graphql.ts	`0.00% <ø> (ø)`
...ent/ui/shareable-resource-detail-metadata-item.tsx	`100.00% <100.00%> (ø)`
... and 42 more

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b474ccf...31e1556. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-03-05T08:22:05Z

Summary

Tests 📝	Passed ✅	Failed ❌	Skipped ⏭️	Other ❓	Flaky 🍂	Duration ⏱️
35	35	0	0	0	0	3m 31s

Insights

Average Tests per Run	Total Flaky Tests	Total Failed	Slowest Test (p95)
35	0	0	22.5s

Suites

35 passed, 0 failed, and 0 other

Suite	Passed	Failed	Other	Duration
✅ app/apps/portal-e2e-tests/tests/tests_files/api/user.spec.ts ✅ should prevent user to update another one when he does not have MANAGE_ACCESS ✅ should allow user to update another one when he has ADMINISTRATE_ORGANIZATION ✅ should allow user to update another one when he has MANAGE_ACCESS	✅ 3	❌ 0	⏭️ 0	3.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/capabilities.spec.ts ✅ Should add subscription with capabilities	✅ 1	❌ 0	⏭️ 0	22.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/csv-feeds.spec.ts ✅ Should add CSV Feed ✅ Should delete CSV Feed from the list ✅ Should delete CSV Feed from the detailed page	✅ 3	❌ 0	⏭️ 0	18.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/custom-dashboards.spec.ts ✅ Should add custom dashboard ✅ Should see the custom dashboard on public page ✅ Should edit a custom dashboard	✅ 3	❌ 0	⏭️ 0	27.2s
✅ app/apps/portal-e2e-tests/tests/tests_files/document.spec.ts ✅ should perform complete CRUD operations on documents	✅ 1	❌ 0	⏭️ 0	4.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/one-click-deploy.spec.ts ✅ should send telemetry event	✅ 1	❌ 0	⏭️ 0	6.2s
✅ app/apps/portal-e2e-tests/tests/tests_files/organization-switcher.spec.ts ✅ Should see registered platforms, subscriptions and trials	✅ 1	❌ 0	⏭️ 0	4.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/organizations.spec.ts ✅ should perform complete CRUD operations on organizations	✅ 1	❌ 0	⏭️ 0	5.3s
✅ app/apps/portal-e2e-tests/tests/tests_files/profile.spec.ts ✅ should update user profile information	✅ 1	❌ 0	⏭️ 0	4.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/public/redirections.spec.ts ✅ should redirect user between public pages and login page	✅ 1	❌ 0	⏭️ 0	2.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/registration.spec.ts ✅ should register openAEV platform ✅ should register openCTI platform	✅ 2	❌ 0	⏭️ 0	5.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-management.spec.ts ✅ should be able to admin service	✅ 1	❌ 0	⏭️ 0	9.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-pictures.spec.ts ✅ should be able to add pictures to a service	✅ 1	❌ 0	⏭️ 0	4.2s
✅ app/apps/portal-e2e-tests/tests/tests_files/streams.spec.ts ✅ Should add Stream ✅ Should delete Stream from the list ✅ Should delete Stream from the detailed page	✅ 3	❌ 0	⏭️ 0	20.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/taxii-feeds.spec.ts ✅ Should add TAXII Feed ✅ Should delete TAXII Feed from the list ✅ Should delete TAXII Feed from the detailed page	✅ 3	❌ 0	⏭️ 0	19.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/third-party-integrations.spec.ts ✅ Should add Third Party Integration ✅ Should delete Third Party Integration from the list ✅ Should delete Third Party Integration from the detailed page	✅ 3	❌ 0	⏭️ 0	19.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/user.spec.ts ✅ Should perform complete CRUD of users as BYPASS ✅ Should only see authorized users ✅ Should not edit first and last name as MANAGE_ACCESS user	✅ 3	❌ 0	⏭️ 0	15.5s
✅ app/apps/portal-e2e-tests/tests/tests_files/xtm-suite-roadmap.spec.ts ✅ Should allow Filigran user to perform a CRUD of an epic ✅ Should allow users that are not connected to view the xtm suite roadmap ✅ Should allow community user to view the xtm suite roadmap	✅ 3	❌ 0	⏭️ 0	15.2s

_{🎉 No failed tests in this run. | 🍂 No flaky tests in this run.}

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Copilot

Pull request overview

This PR extends the integration and connector service forms to support updating multiple images, and adds datasheet_url and demo_url fields to all integration types. It refactors shared form field logic into a centralized useServiceFormFields hook (renamed from useSimpleServiceFormField), adds a new ConnectorForm for editing connectors, introduces the DocumentSourceType enum to distinguish internal vs. external images, and adds a carousel to connector slug views.

Changes:

Added datasheet_url and demo_url fields across all integration types (schema, resolvers, metadata, forms, detail views, i18n)
Refactored image handling to differentiate between internal and external source types, including a migration to mark existing connector images as external
Created a ConnectorForm component and enabled connector editing/updating in the UI, previously restricted

Reviewed changes

Copilot reviewed 56 out of 58 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
`apps/portal-api/src/modules/services/document/opencti/integrations/integrations.graphql`	Added `datasheet_url` and `demo_url` to all integration GraphQL types
`apps/portal-api/src/modules/services/document/opencti/integrations/integrations.model.ts`	Added `datasheet_url`/`demo_url` metadata keys and typed `Integration`
`apps/portal-api/src/modules/services/document/document.graphql`	Added `DocumentSourceType` enum and `source_type` to `ShareableResource`
`apps/portal-api/src/modules/services/document/document.app.ts`	Added boolean metadata conversion, renamed `upsertDocument` to `upsertDocumentWithExternalImage`
`apps/portal-api/src/modules/services/document/document.helper.ts`	Added `BOOLEAN_METADATA`, `INTEGRATION_CONNECTOR_METADATA`, fixed `file.name` → `file.filename`
`apps/portal-api/src/modules/services/document/domain/document.children.domain.ts`	Refactored to support `sourceType` param, renamed methods for external image handling
`apps/portal-api/src/modules/services/document/document.resolver.ts`	Added `ShareableResource` type cast for children_documents
`apps/portal-api/src/modules/ingest-manifest/ingest-manifest.helper.ts`	Use `DocumentSourceType.External` enum value
`apps/portal-api/src/modules/ingest-manifest/ingest-manifest.domain.ts`	Use renamed `upsertDocumentWithExternalImage`
`apps/portal-api/src/modules/services/public_roadmap/epic.app.ts`	Use `DocumentSourceType.Internal` enum value
`apps/portal-api/src/migrations/20260305082651_mark-connector-pictures-external.js`	Migration to mark connector child images as external
`apps/portal-api/src/__generated__/resolvers-types.ts`	Generated types with new fields
`apps/portal-api/package.json`	Added `@types/graphql-upload`
`apps/portal-front/schema.graphql`	Frontend schema with new enum and fields
`apps/portal-front/src/components/service/form/use-service-form-fields.tsx`	Centralized form fields hook with disabled fields support
`apps/portal-front/src/components/service/form/multiple-images-field.tsx`	Added `source_type` support, disable delete for external images
`apps/portal-front/src/components/service/form/description-field.tsx`	Added `disabled` prop
`apps/portal-front/src/components/service/form/uploader-id-field.tsx`	Added `disabled` prop
`apps/portal-front/src/components/service/form/uploader-organization-id-field.tsx`	Added `disabled` prop
`apps/portal-front/src/components/service/form/use-cases-field.tsx`	Added `disabled` prop
`apps/portal-front/src/components/service/form/integration-subtype-field.tsx`	Added `disabled` prop
`apps/portal-front/src/components/service/integrations/forms/connector-form.tsx`	New connector editing form
`apps/portal-front/src/components/service/integrations/forms/csv-feed-form.tsx`	Refactored to use `useServiceFormFields`, added new URL fields
`apps/portal-front/src/components/service/integrations/forms/stream-form.tsx`	Refactored to use `useServiceFormFields`, added new URL fields
`apps/portal-front/src/components/service/integrations/forms/taxii-feed-form.tsx`	Refactored to use `useServiceFormFields`, added new URL fields
`apps/portal-front/src/components/service/integrations/forms/third-party-integration-form.tsx`	Refactored to use `useServiceFormFields`, added new URL fields
`apps/portal-front/src/components/service/document/shareable-resource-slug.tsx`	Moved carousel inside, added `carouselImages` logic
`apps/portal-front/src/components/service/document/ui/shareable-resource-carousel-view.tsx`	Refactored to accept `images` prop instead of `documentData`
`apps/portal-front/src/components/service/document/shareable-resouce-details.tsx`	Added datasheet/demo URL display
`apps/portal-front/src/components/service/document/connector/shareable-resource-connector-slug.tsx`	Added carousel, manage sheet, `serviceInstance` prop
`apps/portal-front/src/components/service/document/connector/shareable-resource-connector-slug-public.tsx`	Added carousel, `serviceInstance` prop
`apps/portal-front/src/components/service/document/connector/shareable-resource-connector-details.tsx`	Added datasheet/demo URL display
`apps/portal-front/src/components/service/document/document.graphql.ts`	Added `source_type`, `datasheet_url`, `demo_url` to fragments
`apps/portal-front/src/components/service/document/public-document.graphql.ts`	Added `datasheet_url`, `demo_url`
`apps/portal-front/src/components/service/document/use-document-context.ts`	Added ConnectorForm mapping
`apps/portal-front/src/components/service/components/service-card.tsx`	Simplified update capability check
`apps/portal-front/src/components/service/components/service-list.tsx`	Fixed React key warning with Fragment
`apps/portal-front/src/components/service/components/subscribable-services.types.ts`	Added ConnectorForm types
`apps/portal-front/src/components/service/custom-dashboards/`	Refactored to use centralized form hook
`apps/portal-front/src/components/service/openaev-scenarios/`	Refactored to use centralized form hook
`apps/portal-front/src/components/ui/MarkdownInput.tsx`	Added `disabled` prop
`apps/portal-front/src/components/ui/select-users.tsx`	Added `disabled` prop
`apps/portal-front/messages/en.json`	Added English translations
`apps/portal-front/messages/fr.json`	Added French translations
`apps/portal-front/package.json`	Updated `@filigran/ui` to 0.44.8
`apps/portal-e2e-tests/tests/model/integration.pageModel.ts`	Updated label text for URL fields
`apps/portal-api/src/modules/services/document/domain/document.children.domain.test.ts`	New tests for external image handling
`apps/portal-api/src/modules/services/document/document.app.test.ts`	Tests for boolean metadata and upsert
`.github/agents/api-test-writer.agent.md`	New agent definition
`yarn.lock`	Updated dependencies

Files not reviewed (1)

apps/portal-api/src/generated/resolvers-types.ts: Language not supported

You can also share your feedback on Copilot code review. Take the survey.

…demo URLs

…forms

… forms

…e property

…rm hook

…n public page

…d edition (#1899) * [backend] feat: split files for document, images and logo in createDocument * [backend] chore: add migration to populate image_type document metadata * [backend] refactor: use object with name properties as parameter of updateDocument * [frontend] feat(resource-creation): split images and logo in forms * [frontend] feat: display logo and images identified by their type * [backend/frontend] feat(document): allow edition of images and logo * [backend/frontend] chore: implement review comments * [backend/frontend] refactor: clean pull request and add missing tests * [backend/frontend] refactor: distinguish sourceDocument from DB document * [backend/frontend] chore: implement review comments * [backend] fix(document): delete document to fix tests * [frontend] fix(form): use correct name for sourceDocument file * [frontend] fix: use sourceDocument when adding vault file * [frontend] feat(resource): add ability to delete a logo * [frontend] feat(form): hide logo file name

github-actions bot assigned Kroustille Mar 5, 2026

github-actions bot added the Filigran Team use to identify PR from the Filigran team label Mar 5, 2026

Kroustille force-pushed the issue/1404 branch from 2f2b78b to 294c81c Compare March 5, 2026 08:08

Kroustille force-pushed the issue/1404 branch 3 times, most recently from 2a5ba16 to bd6f9b3 Compare March 5, 2026 09:50

Kroustille changed the title ~~Issue/1404~~ [backend/frontend] feat(integrations): add ability to update multiple images, demo and datasheet url (#1404) Mar 5, 2026

Kroustille requested a review from Copilot March 5, 2026 09:51

Copilot started reviewing on behalf of Kroustille March 5, 2026 09:52 View session

Kroustille force-pushed the issue/1404 branch from 46abceb to e1760bb Compare March 5, 2026 09:52

Copilot AI reviewed Mar 5, 2026

View reviewed changes

Comment thread apps/portal-api/package.json Outdated

Comment thread apps/portal-front/src/components/service/integrations/forms/connector-form.tsx Outdated

Kroustille added 16 commits March 5, 2026 14:30

[backend/frontend] feat(integrations): add and display datasheet and …

fcbadd2

…demo URLs

[frontend] feat(integrations): add datasheet and demo link fields in …

a613305

…forms

[frontend] feat(services): mutualize multiple images component across…

2781b36

… forms

[frontend] feat(services): display integration images in a carousel

d1388d7

[frontend] refactor(services): rename useSimpleServiceFormField hook

6ca30bb

[frontend] chore: add possibility to disable service form fields

3051a9c

[frontend] feat: add ability to update a connector urls and images

8525054

[frontend] feat: display carousel on connector pages

16828bb

[frontend] chore: use first third party integration image as logo

02ce9da

[frontend] fix: allow deletion of datasheet or demo URLs

f9ddca7

[backend] chore: replace only external image by connector logo

a6dc579

[backend] test: add tests for document app and document children domain

8a4f0be

[backend] chore: add migration to mark connector images as external

a54dfc0

[backend/frontend] refactor: use GraphQL enum for document source typ…

2329175

…e property

[frontend] chore: disable image edition when it is from external source

e084fde

[backend/frontend] chore: implement copilot review comments

3230692

Kroustille force-pushed the issue/1404 branch from e1760bb to 3230692 Compare March 5, 2026 13:31

Kroustille marked this pull request as ready for review March 5, 2026 13:42

carinelebas approved these changes Mar 5, 2026

View reviewed changes

Kroustille added 2 commits March 5, 2026 15:54

Merge branch 'development' into issue/1404

fada5a8

[backend/frontend] chore: implement review comments

6f78017

Kroustille added the needs feature env Indicate if the PR needs an associated feature environment label Mar 5, 2026

Kroustille and others added 9 commits March 5, 2026 18:27

Merge branch 'development' into issue/1404

a6ef5ee

[frontend] refactor(service-form): move images states into service fo…

b594866

…rm hook

[frontend] fix(third-party): do not display first image in carousel o…

610d2fc

…n public page

[frontend] fix: display filigran logo for dashboards and scenarios

cd1a669

Merge branch 'development' into issue/1404

368ebf4

Merge branch 'development' into issue/1404

74b9f21

Merge branch 'development' into issue/1404

f254ca8

Merge branch 'development' into issue/1404

bb51805

Kroustille changed the title ~~[backend/frontend] feat(integrations): add ability to update multiple images, demo and datasheet url (#1404)~~ [backend/frontend] feat(integrations): add ability to update multiple images, demo and datasheet url (#1404) (#1837) Mar 25, 2026

Merge branch 'development' into issue/1404

31e1556

Kroustille enabled auto-merge (squash) March 25, 2026 12:43

Kroustille merged commit ab80615 into development Mar 25, 2026
19 checks passed

Kroustille deleted the issue/1404 branch March 25, 2026 12:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[backend/frontend] feat(integrations): add ability to update multiple images, demo and datasheet url (#1404) (#1837)#1826

[backend/frontend] feat(integrations): add ability to update multiple images, demo and datasheet url (#1404) (#1837)#1826
Kroustille merged 28 commits intodevelopmentfrom
issue/1404

Kroustille commented Mar 5, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Kroustille commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Context

How to test

Related issues

Checklist

Quality

Testing

What tests have been made

Additional information

Uh oh!

codecov bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Insights

Suites

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Kroustille commented Mar 5, 2026 •

edited

Loading

codecov bot commented Mar 5, 2026 •

edited

Loading

github-actions bot commented Mar 5, 2026 •

edited

Loading