Skip to content

[backend] - (Trials): Fix global search bypassing platform_identifier filter #1853#1859

Merged
Antoine-Quintin merged 3 commits intodevelopmentfrom
issue/1853
Mar 16, 2026
Merged

[backend] - (Trials): Fix global search bypassing platform_identifier filter #1853#1859
Antoine-Quintin merged 3 commits intodevelopmentfrom
issue/1853

Conversation

@Antoine-Quintin
Copy link
Copy Markdown
Contributor

@Antoine-Quintin Antoine-Quintin commented Mar 13, 2026

Context

Briefly describe the purpose and context of this PR. Include relevant screenshots or screen recordings for the product team.

When using the search bar in the OpenAEV Trials admin interface, results from OpenCTI Trials were incorrectly appearing, and vice versa.

image image

How to test

Provide step-by-step instructions to test your changes. Include screenshots of your local testing results.

  1. Create trials with different platform_identifier values (opencti and openaev)
  2. Go to the OpenAEV Trials admin page (/app/admin/openaev-trials)
  3. Type an organization name or email in the search bar
  4. Verify that only OpenAEV trials appear — no OpenCTI trials in the results
  5. Repeat on the OpenCTI Trials page (/app/admin/opencti-trials) and verify the same isolation

Related issues

Checklist

Quality

  • I consider this work complete and ready for review
  • I tested all features and edge cases
  • I refactored code where necessary to improve quality
  • I made sure my code meets development guidelines
  • I performed a self-review of my code

Testing

  • I wrote test cases for the relevant use cases (unit, integration or e2e tests)
  • (Bug fixes only) I added tests that reproduce and verify the fix

What tests have been made

  • Unit tests
  • Integration tests
  • E2E tests
  • Local manual tests

Additional information

Any additional context, dependencies, or concerns reviewers should know about.

@Antoine-Quintin Antoine-Quintin requested a review from a team March 13, 2026 14:03
@Antoine-Quintin Antoine-Quintin added bug use for describing something not working as expected P1 - High Must be fixed during the week needs feature env Indicate if the PR needs an associated feature environment labels Mar 13, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.36%. Comparing base (f1f9f16) to head (067e465).
⚠️ Report is 1 commits behind head on development.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           development    #1859   +/-   ##
============================================
  Coverage        34.36%   34.36%           
============================================
  Files              649      649           
  Lines            41128    41132    +4     
  Branches          2362     2363    +1     
============================================
+ Hits             14132    14136    +4     
  Misses           26723    26723           
  Partials           273      273           
Files with missing lines Coverage Δ
...modules/services/deployments/deployments.domain.ts 98.75% <100.00%> (+0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1f9f16...067e465. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
32 32 0 0 0 0 3m 20s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
32 0 0 23.7s

Suites

32 passed, 0 failed, and 0 other

Suite Passed Failed Other Duration
✅ app/apps/portal-e2e-tests/tests/tests_files/api/user.spec.ts
        ✅ should prevent user to update another one when he does not have MANAGE_ACCESS
        ✅ should allow user to update another one when he has ADMINISTRATE_ORGANIZATION
        ✅ should allow user to update another one when he has MANAGE_ACCESS
✅ 3 ❌ 0 ⏭️ 0 3.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/capabilities.spec.ts
        ✅ Should add subscription with capabilities
✅ 1 ❌ 0 ⏭️ 0 23.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/csv-feeds.spec.ts
        ✅ Should add CSV Feed
        ✅ Should delete CSV Feed from the list
        ✅ Should delete CSV Feed from the detailed page
✅ 3 ❌ 0 ⏭️ 0 19.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/custom-dashboards.spec.ts
        ✅ Should add custom dashboard
        ✅ Should see the custom dashboard on public page
        ✅ Should edit a custom dashboard
✅ 3 ❌ 0 ⏭️ 0 28.3s
✅ app/apps/portal-e2e-tests/tests/tests_files/document.spec.ts
        ✅ should perform complete CRUD operations on documents
✅ 1 ❌ 0 ⏭️ 0 4.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/one-click-deploy.spec.ts
        ✅ should send telemetry event
✅ 1 ❌ 0 ⏭️ 0 6.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/organization-switcher.spec.ts
        ✅ Should see registered platforms, subscriptions and trials
✅ 1 ❌ 0 ⏭️ 0 4.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/organizations.spec.ts
        ✅ should perform complete CRUD operations on organizations
✅ 1 ❌ 0 ⏭️ 0 5.3s
✅ app/apps/portal-e2e-tests/tests/tests_files/profile.spec.ts
        ✅ should update user profile information
✅ 1 ❌ 0 ⏭️ 0 4.9s
✅ app/apps/portal-e2e-tests/tests/tests_files/public/redirections.spec.ts
        ✅ should redirect user between public pages and login page
✅ 1 ❌ 0 ⏭️ 0 3.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/registration.spec.ts
        ✅ should register openAEV platform
        ✅ should register openCTI platform
✅ 2 ❌ 0 ⏭️ 0 5.7s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-management.spec.ts
        ✅ should be able to admin service
✅ 1 ❌ 0 ⏭️ 0 9.6s
✅ app/apps/portal-e2e-tests/tests/tests_files/service-pictures.spec.ts
        ✅ should be able to add pictures to a service
✅ 1 ❌ 0 ⏭️ 0 4.1s
✅ app/apps/portal-e2e-tests/tests/tests_files/streams.spec.ts
        ✅ Should add Stream
        ✅ Should delete Stream from the list
        ✅ Should delete Stream from the detailed page
✅ 3 ❌ 0 ⏭️ 0 19.4s
✅ app/apps/portal-e2e-tests/tests/tests_files/taxii-feeds.spec.ts
        ✅ Should add TAXII Feed
        ✅ Should delete TAXII Feed from the list
        ✅ Should delete TAXII Feed from the detailed page
✅ 3 ❌ 0 ⏭️ 0 19.8s
✅ app/apps/portal-e2e-tests/tests/tests_files/third-party-integrations.spec.ts
        ✅ Should add Third Party Integration
        ✅ Should delete Third Party Integration from the list
        ✅ Should delete Third Party Integration from the detailed page
✅ 3 ❌ 0 ⏭️ 0 20.0s
✅ app/apps/portal-e2e-tests/tests/tests_files/user.spec.ts
        ✅ Should perform complete CRUD of users as BYPASS
        ✅ Should only see authorized users
        ✅ Should not edit first and last name as MANAGE_ACCESS user
✅ 3 ❌ 0 ⏭️ 0 15.4s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

@Antoine-Quintin Antoine-Quintin marked this pull request as ready for review March 13, 2026 14:16
@Antoine-Quintin Antoine-Quintin merged commit 9a0cd32 into development Mar 16, 2026
16 checks passed
@Antoine-Quintin Antoine-Quintin deleted the issue/1853 branch March 16, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug use for describing something not working as expected needs feature env Indicate if the PR needs an associated feature environment P1 - High Must be fixed during the week

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants