-
Notifications
You must be signed in to change notification settings - Fork 304
Add build script for iOS #1677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build script for iOS #1677
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks pretty good, thanks! I really need a CI pipeline for this, otherwise this build script will just become some unmaintained junk of code.
I'm migrating away from AzureCI and prefer to use GitHub Actions by now. Have you had experience with GitHub Actions and could you provide a CI pipeline on your own?
@DominusExult FYI
Thank you for responding! I also agree with your point. |
|
I've used an Xcode project that I created from scratch to work for Exult's iOS port. I didn't need to use either CoreAudio or SDL3 to get FluidSynth to put out music. JFYI |
…quired for app store upload
Oh thank you a lot for sharing!! It definitely helped me a lot. In fact, the build script would not be possible without your fluidsynth-sans-glib port 🥰 |
|
@derselbst It took some time to finalize the iOS CI script since it depended on a change in the SDL3 repository (libsdl-org/SDL#14259) |
|
Really nice, thanks! Two last points: For Android we publish the binaries to allow downstream projects to consume them directly. Would it make sense to do the same for iOS? And if so, how would the folder structure look like? And: I would probably want to get rid of the |
Thanks! I've moved the iOS build script to |
|
Another note on xcframework, you need to make sure to include the dSYM files for distribution. |
Thanks! I've added it as well :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your efforts! LGTM, I'll merge it now to the ios branch, to add a build badge to the readme and publish the binaries as mentioned.
This PR enables building a FluidSynth dynamic framework for iOS.
CMAKE_SYSTEM_NAMEtoiOS, some parts of CMakeLists.txt were modified to support that case.<CoreAudio/AudioHardware.h>is not available for iOS, SDL3 instead of CoreAudio is built alongside Fluidsynth as the audio driver.There have been forks that made iOS build possible (like https://github.com/DominusExult/fluidsynth-sans-glib), but they do not support FluidSynth v2.5.0+ since they modified the sources heavily.
I'm an Android / iOS developer working on a music-playing app and have successfully incorporated your library in my app with the build script. I want to contribute back to enable other iOS developers as well to build and use the library easily.
An example app can be provided if needed.
Sadly, I haven't tried Azure CI before. If you can help me a little, I can provide iOS framework CI checks as well.