Skip to content

Fix precompiled Windows binaries #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2025
+49 −10
Merged

Fix precompiled Windows binaries #1689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
59 changes: 49 additions & 10 deletions .github/workflows/windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,24 @@ jobs:
@ECHO ON
cd build
cmake --build . --config Release --target install || exit /b 1
del "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\concrt*.dll" 2>nul || exit 0
del "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\vcruntime*.dll" 2>nul || exit 0
del "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\msvcp*.dll" 2>nul || exit 0
rmdir "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\lib\x86" 2>nul || exit 0
rmdir "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\lib\x64" 2>nul || exit 0
del "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\concrt*.dll"
del "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\vcruntime*.dll"
del "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\msvcp*.dll"
rmdir "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\lib\x86"
rmdir "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\lib\x64"

cd d:\deps\bin\
dir
COPY SDL3.dll "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\
COPY sndfile.dll "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\
if "${{ matrix.osal }}"=="glib" (
COPY libglib-2.0-0.dll "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\
COPY libgobject-2.0-0.dll "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\
COPY libgthread-2.0-0.dll "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\
COPY intl.dll "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\
COPY libintl-8.dll "${{ github.workspace }}\${{ env.INSTALL_LOCATION }}\bin\
)
exit 0

- name: Validate library
shell: bash
Expand All @@ -176,7 +189,7 @@ jobs:
if [[ "${{ github.event_name }}" == "release" ]]; then
echo "name=fluidsynth-${{ github.event.release.tag_name }}" >> $GITHUB_OUTPUT
else
echo "name=CI-${{ github.run_id }}" >> $GITHUB_OUTPUT
echo "name=fluidsynth-${{ github.run_id }}" >> $GITHUB_OUTPUT
fi

- name: Upload Artifacts
Expand Down Expand Up @@ -513,29 +526,54 @@ jobs:
retention-days: 14
overwrite: true

acceptance-test:
needs:
- msvc-build
- msys2-build
- mingw-build
runs-on: windows-2022
name: 🧪 Acceptance Test
steps:
- name: Download all artifacts
uses: actions/download-artifact@v5
with:
path: artifacts
pattern: fluidsynth-*
merge-multiple: false

- name: Try to execute fluidsynth
shell: bash
run: |
set -ex
cd artifacts
for dir in */; do
echo "Testing artifact $dir"
"$dir/bin/fluidsynth.exe" --version
done

# Publish artifacts to GitHub releases (only on release events)
publish-release:
if: github.event_name == 'release' && github.event.action == 'published'
needs: [msvc-build]
needs:
- acceptance-test
- msvc-build
runs-on: ubuntu-latest
name: 🚀 Publish Release Artifacts
steps:
- name: Download all artifacts
uses: actions/download-artifact@v5
with:
path: artifacts
pattern: fluidsynth-*
merge-multiple: false
tag_name: ${{ github.event.release.tag_name }}

- name: Create release archives
run: |
cd artifacts
ls -la
for dir in */; do
if [[ "$dir" == fluidsynth* ]]; then
echo "Creating archive for $dir"
zip -r "${dir%/}.zip" "$dir"
fi
done
ls -la *.zip

Expand All @@ -552,6 +590,7 @@ jobs:
if: github.event_name == 'release' && github.event.action == 'published'
needs: [publish-release]
runs-on: ubuntu-22.04
name: 📢 Announce Release
steps:
- uses: actions/checkout@v5
with:
Expand Down