removing old deprecations and Optimise module #2412
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcabbott
reviewed
Mar 26, 2024
Comment on lines
45
to
57
| # Channel notation: Changed to match Conv, but very softly deprecated! | ||
| # Perhaps change to @deprecate for v0.15, but there is no plan to remove these. | ||
| Dense(in::Integer, out::Integer, σ = identity; kw...) = | ||
| Dense(in => out, σ; kw...) | ||
| Bilinear(in1::Integer, in2::Integer, out::Integer, σ = identity; kw...) = | ||
| Bilinear((in1, in2) => out, σ; kw...) | ||
| Embedding(in::Integer, out::Integer; kw...) = Embedding(in => out; kw...) | ||
|
|
||
| RNNCell(in::Integer, out::Integer, σ = tanh; kw...) = RNNCell(in => out, σ; kw...) | ||
| LSTMCell(in::Integer, out::Integer; kw...) = LSTMCell(in => out; kw...) | ||
|
|
||
| GRUCell(in::Integer, out::Integer; kw...) = GRUCell(in => out; kw...) | ||
| GRUv3Cell(in::Integer, out::Integer; kw...) = GRUv3Cell(in => out; kw...) |
There was a problem hiding this comment.
Most of this would be great to delete!
These lines though, I wonder if we should keep. Or change them to print a depwarn.
There was a problem hiding this comment.
yes I'll deprecate them
CarloLucibello
force-pushed
the
cl/params
branch
from
8cf0475 to
efedbdf
Compare
Merged
|
closing in favor of #2495 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last part of #1986