Skip to content

Conversation

@ThibautCuchet
Copy link

@ThibautCuchet ThibautCuchet commented Feb 22, 2024

Definition of Done

General

The SmartActionOptions type was missing the props baseUrl available in the forest-express package.

  • Write an explicit title for the Pull Request, following Conventional Commits specification
  • Test manually the implemented changes
  • Validate the code quality (indentation, syntax, style, simplicity, readability)
  • Ensure that Types have been updated according to your changes (if needed)

Security

  • Consider the security impact of the changes made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant