Skip to content

fix(validations): ignore default before validations #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024
Merged

fix(validations): ignore default before validations #708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion app/services/forest_liana/schema_adapter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,11 @@ def add_default_value(column_schema, column)
def add_validations(column_schema, column)
# NOTICE: Do not consider validations if a before_validation Active Records
# Callback is detected.
if @model._validation_callbacks.map(&:kind).include? :before
default_callback_excluded = [:normalize_changed_in_place_attributes]
if @model._validation_callbacks
.reject { |callback| default_callback_excluded.include?(callback.filter) }
.map(&:kind).include?(:before)

return column_schema
end

Expand Down
Loading