Skip to content

Stop using typescript module syntax#3077

Open
vinassefranche wants to merge 4 commits intoFormidableLabs:mainfrom
vinassefranche:use-modern-typescript-namespace
Open

Stop using typescript module syntax#3077
vinassefranche wants to merge 4 commits intoFormidableLabs:mainfrom
vinassefranche:use-modern-typescript-namespace

Conversation

@vinassefranche
Copy link

@vinassefranche vinassefranche commented Feb 25, 2026

Description

Typescript has deprecated the module syntax. When trying to typecheck our codebase with the latest typescript-go version, we have errors coming from victory (caused by this recent change):

A 'namespace' declaration should not be declared using the 'module' keyword. Please use the 'namespace' keyword instead.

120 export module List {

This pull request replaces the use of the module keyword with the namespace keyword.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run all builds, tests, and linting and all checks pass
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@vercel
Copy link

vercel bot commented Feb 25, 2026

@vinassefranche is attempting to deploy a commit to the formidable-labs Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Feb 25, 2026

🦋 Changeset detected

Latest commit: 9dd1524

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
victory-core Patch
victory-area Patch
victory-axis Patch
victory-bar Patch
victory-box-plot Patch
victory-brush-container Patch
victory-brush-line Patch
victory-candlestick Patch
victory-canvas Patch
victory-chart Patch
victory-create-container Patch
victory-cursor-container Patch
victory-errorbar Patch
victory-group Patch
victory-histogram Patch
victory-legend Patch
victory-line Patch
victory-pie Patch
victory-polar-axis Patch
victory-scatter Patch
victory-selection-container Patch
victory-shared-events Patch
victory-stack Patch
victory-tooltip Patch
victory-voronoi-container Patch
victory-voronoi Patch
victory-zoom-container Patch
victory Patch
victory-native Patch
victory-vendor Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant