Change MEDIAEMBED_THEME rendering parameter #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a proof of concept because it's not really doing things the way we expect.
We should update the
MEDIAEMBED_THEMErendering parameter based on the selected theme. Unfortunately I'm not sure we can change this value per-request in Flarum since theFormatter::configureextender only runs after a cache clear. There's also no way to access the actor or cookies from that extender so it would require additional code.This PR is a working solution to always apply the default theme value as the MediaEmbed theme.
Confirmed
composer test).Required changes: