Add deployment markers to sitespeed graphs#605
Merged
Conversation
Co-authored-by: shyim <6224096+shyim@users.noreply.github.com>
Co-authored-by: shyim <6224096+shyim@users.noreply.github.com>
c4eb35b to
c8afc91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds vertical dashed line markers to sitespeed performance graphs showing when deployments occurred, similar to Tideways deployment annotations.
Changes
chartjs-plugin-annotationdependency (v3.1.0)Implementation
The sitespeed data already includes
deploymentIdforeign key references. The implementation:Annotations are then applied to all chart instances via the Chart.js plugin configuration.
Original prompt