Trait coherence: disallow inherent impls on external types #7385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tritao
added
compiler
tritao
had a problem deploying
to
fuel-sway-bot
GitHub Actions
Error
tritao
force-pushed
the
improve-trait-coherence-checks
branch
from
0d7b96a to
4c72c34
Compare
tritao
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
CodSpeed Performance ReportMerging #7385 will not alter performanceComparing Summary
|
This improves the trait coherence checks for impl self case, and polishes a bit of the wording on the existing diagnostics. * Add CompileError::InherentImplForExternalType and diagnostics. Reason/issue/help now refer to "package" to match coherence scope * Enforce package-level check in impl-self type checking Reject inherent impls for external nominal types (struct/enum) Temporary whitelist: allow inherent impls on std::storage::StorageKey<_> This is a workaround so current code that uses this pattern keeps working.
tritao
force-pushed
the
improve-trait-coherence-checks
branch
from
4c72c34 to
70828a8
Compare
tritao
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
tritao
temporarily deployed
to
fuel-sway-bot
GitHub Actions
Inactive
IGI-111
reviewed
Sep 22, 2025
Comment on lines
+551
to
+561
| // Temporary workaround: allow inherent impls on `std::storage::StorageKey<_>`. | ||
| let is_storage_key_in_std = match &*type_engine.get(implementing_for.type_id()) { | ||
| TypeInfo::Struct(decl_id) => { | ||
| let s = decl_engine.get_struct(decl_id); | ||
| s.call_path.suffix.as_str() == "StorageKey" | ||
| && s.call_path.prefixes.len() >= 2 | ||
| && s.call_path.prefixes[0].as_str() == "std" | ||
| && s.call_path.prefixes[1].as_str() == "storage" | ||
| } | ||
| _ => false, | ||
| }; |
There was a problem hiding this comment.
I thought that, as we discussed, this whitelisting wasn't actually necessary for licit usages of impl StorageKey<SomeType>
There was a problem hiding this comment.
Yep, I will rework this PR
kmk142789
approved these changes
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the trait coherence checks for impl self case, and polishes a bit of the wording on the existing diagnostics.
We now enforce package-level check in impl-self type checking, which means we now reject inherent impls for external nominal types (struct/enum).
There is still is a specialized whitelist for
StorageKeyso current code that uses this pattern keeps working.Checklist
Breaking*orNew Featurelabels where relevant.