Fix namespace issue in isDialectOp
#106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsymalla-AMD
requested review from
Flakebi and
nhaehnle
and removed request for
nhaehnle
jasilvanus
reviewed
Oct 2, 2024
tsymalla
force-pushed
the
fix_dialect_name_vs_namespace
branch
from
6338bda to
3bc5d6a
Compare
added 3 commits
October 2, 2024 14:35
tsymalla
force-pushed
the
fix_dialect_name_vs_namespace
branch
from
3bc5d6a to
113c4dd
Compare
jasilvanus
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is using the
cppNamespace. Use the IR-level namespace instead.