Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/_validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,18 +62,18 @@ jobs:
if: steps.playwright-cache.outputs.cache-hit != 'true'

# While most of the test suite is self-contained, the tests for the demo
# servers require a prod build of @atj/server.
# servers require a prod build of @gsa-tts/forms-server.
- name: Build
run: pnpm build

- name: Make directory for build artifacts
run: mkdir -p output/build-artifacts

- name: Spotlight app performance budget
run: pnpm --filter @atj/spotlight size:ci > output/build-artifacts/spotlight-size-output.txt
run: pnpm --filter @gsa-tts/forms-spotlight size:ci > output/build-artifacts/spotlight-size-output.txt

- name: Design package performance budget
run: pnpm --filter @atj/design size:ci > output/build-artifacts/design-size-output.txt
run: pnpm --filter @gsa-tts/forms-design size:ci > output/build-artifacts/design-size-output.txt

- name: Upload size:ci results
uses: actions/upload-artifact@v4
Expand Down
2 changes: 1 addition & 1 deletion packages/design/.storybook/main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const config: StorybookConfig = {
addons: [
getAbsolutePath('@storybook/addon-links'),
getAbsolutePath('@storybook/addon-essentials'),
getAbsolutePath('@storybook/addon-interactions'),
//getAbsolutePath('@storybook/addon-interactions'),
getAbsolutePath('@storybook/addon-a11y'),
getAbsolutePath('@storybook/addon-coverage'),
getAbsolutePath('@storybook/experimental-addon-test'),
Expand Down
1 change: 0 additions & 1 deletion packages/design/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
"@storybook/addon-a11y": "^8.4.7",
"@storybook/addon-coverage": "^1.0.5",
"@storybook/addon-essentials": "^8.4.7",
"@storybook/addon-interactions": "^8.4.7",
"@storybook/addon-links": "^8.4.7",
"@storybook/blocks": "^8.4.7",
"@storybook/experimental-addon-test": "^8.4.7",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ export const PageEdit: PatternEditComponent<PageProps> = props => {
previewProps={{
type: 'sequence',
_patternId: props.previewProps._patternId,
children: props.previewProps.children,
}}
childComponents={props.childComponents}
/>
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import type { Meta, StoryObj } from '@storybook/react';
import { within } from '@testing-library/react';

import { createThreePageFormWithPageRules } from '../../../../test-form.js';
import { createPatternEditStoryMeta } from '../common/story-helper.js';
import { PageEdit } from './index.js';

const blueprint = createThreePageFormWithPageRules();

const storyConfig: Meta<typeof PageEdit> = {
title: 'Edit components/PageEdit',
...createPatternEditStoryMeta({
blueprint,
}),
};
export default storyConfig;

export const CreateCustomRule: StoryObj<typeof PageEdit> = {
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
//const pagesetHeaderElement = await canvas.findByText(/Page 1/);
canvas.getByRole('button', { name: /Create custom rule/ });
//await userEvent.click(button);
},
};
Loading
Loading