Fixes for compiling without Advanced Lighting #2168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaigler
force-pushed
the
AL_disable_fix
branch
from
d3f8120 to
e3d7baa
Compare
Building without Advanced Lighting (TORQUE_ADVANCED_LIGHTING unchecked in CMake) generated linker errors and an alert when the game attempted to set the light manager.
chaigler
force-pushed
the
AL_disable_fix
branch
from
e3d7baa to
91c940a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2167.
Building without Advanced Lighting (TORQUE_ADVANCED_LIGHTING unchecked in CMake) generated linker errors and an alert when the game attempted to set the light manager. This ifdefs the offending code and changes the template (BaseGame only - I didn't update the old Full template) to try to set light managers in order, based on the existing (but unused) $lightManager::defaults pref.