Conversation
Update FindPythia6.cmake
Author
|
Hi @drbenmorgan, @gunterfolger, could you, please, have a look? |
drbenmorgan
reviewed
Mar 11, 2024
cmake/Modules/FindPythia6.cmake
Outdated
| find_library(PYTHIA6_LIBRARY NAMES Pythia6 pythia6-$ENV{PYTHIA6_VERSION} | ||
| HINTS $ENV{PYTHIA6} $ENV{PYTHIA6}/lib) | ||
| find_library(PYTHIA6_LIBRARY NAMES Pythia6 pythia6 pythia6-$ENV{PYTHIA6_VERSION} | ||
| HINTS $ENV{PYTHIA6} $ENV{PYTHIA6}/lib $ENV{PYTHIA6}/lib64 ${PYTHIA8_ROOT_DIR}/lib ${PYTHIA8_ROOT_DIR}/lib64) |
Member
There was a problem hiding this comment.
Should that be PYTHIA6 rather than PYTHIA8 in the last two variables?
Author
There was a problem hiding this comment.
Hi @drbenmorgan, that was a very first PR to lay a fundament to switch examples from hepMC2 to HEpMC3.
Practically I can continue if you have some time.
Member
Author
There was a problem hiding this comment.
Hi @drbenmorgan,
well, one would have to split #45 or #18 into smaller PRs:
- Some CI for github to understand the things are working
- Improvements for the Pythia6/Pythia8/LHAPDF - this is the most important part.
- The update of the examples
Andrii
Member
Author
There was a problem hiding this comment.
Hi @drbenmorgan,
- CI -- see Add Actions CI with custom development container and compilation caching #67. That is quite a solid and fast solution.
- cmake modules for Pythia6/8/LHAPDF can be added within minutes, HepMC3 provides a config for
cmake, so no module is needed. But this makes sense to do after the CI. - The examples themselves should come either togather with cmake modules or later, separately.
Amdrii
Member
|
Many thanks @andriish, this patch is now merged upstream and will be in the next release and patch! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update FindPythia6.cmake to take into account that the libraries might be located in the lib64 subdirectory.