-
Notifications
You must be signed in to change notification settings - Fork 234
Add doctest_skips for xarray<2025.10.1 and update output DataArray repr #4145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Specifically on `_GMT_IMAGE.to_xarray` and `GMTBackendEntrypoint`, due to changes in xarray=2025.10.0 from repr changes to the coords ordering, xref pydata/xarray#10778. Also removed ellipsis and added the size of the DataArray and coordinates in kB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be good to merge after addressing my comments.
Co-authored-by: Dongdong Tian <[email protected]>
|
This solution is not perfect, because when running |
Yes I realized that when running |
Description of proposed changes
Skip doctests using
__doctest_skip__on_GMT_IMAGE.to_xarrayandGMTBackendEntrypoint, due to changes in xarray=2025.10.1 from repr changes to the coords ordering, xref pydata/xarray#10778.Also removed ellipsis and added the size of the DataArray and coordinates in kB.
Fixes #4143
Preview: https://pygmt-dev--4145.org.readthedocs.build/en/4145/api/generated/pygmt.GMTBackendEntrypoint.html
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash command is:
/format: automatically format and lint the code