fix: sort results before constructing coding data#451
Closed
katie-perry wants to merge 1 commit intomainfrom
Closed
fix: sort results before constructing coding data#451katie-perry wants to merge 1 commit intomainfrom
katie-perry wants to merge 1 commit intomainfrom
Conversation
|
PRs require a priority label. Please add one. |
korikuzma
requested changes
Jan 22, 2026
| ) | ||
| if not results: | ||
| return None | ||
| results.sort( |
Member
There was a problem hiding this comment.
Can we update the docstring with this?
Contributor
Author
|
@jarbesfeld has a better place to sort - I thought the fix would be somewhere different and I got a lil too excited to open this PR lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.