fix: remove stream-chat module augmentation from stream-chat-angular #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuperaz
force-pushed
the
drop-generics-fixes
branch
from
e2c99f3 to
bdc7890
Compare
|
🎉 This PR is included in version 6.0.0-rc.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 6.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for: https://linear.app/stream/issue/ANG-31/drop-generics
The previous implementation exported the stream-chat module augmentation to integrators. So the types added by stream-chat-angular were available to integrators by default.
But this is not what we want, we don't want to expose the module augmentation to integrators by default (detailed discussion: https://getstream.slack.com/archives/C06CF5TKRGA/p1741253351122949?thread_ts=1741249865.246039&cid=C06CF5TKRGA)
Unfortunately there is no way to do this with ng-packgr, see this issue: ng-packagr/ng-packagr#1727 (comment)
So I have to manually update the bundle, this is not a nice solution, but I couldn't find a better one.