Skip to content

Add a safe check before before we start writing logs #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 2, 2025
Merged

Add a safe check before before we start writing logs #31

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
337b597
fix: Add a safe check before before we start writing logs to file
rahul-lohra Jul 1, 2025
ee5815c
fix: Add a safe check before before initialising current writer
rahul-lohra Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 29 additions & 4 deletions stream-log-android-file/src/main/kotlin/io/getstream/log/file/FileStreamLogger.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
package io.getstream.log.file

import android.util.Log
import io.getstream.log.Priority
import io.getstream.log.StreamLogger
import io.getstream.log.helper.stringify
Expand Down Expand Up @@ -90,8 +91,14 @@ public class FileStreamLogger(
}

public fun clear(): Unit = executor.execute {
internalFile0.writeText("")
internalFile1.writeText("")

if (internalFile0.exists()) {
internalFile0.writeText("")
}

if (internalFile1.exists()) {
internalFile1.writeText("")
}
}

private fun initIfNeeded() {
Expand All @@ -101,8 +108,26 @@ public class FileStreamLogger(
internalFile0.lastModified() > internalFile1.lastModified() -> internalFile0
else -> internalFile1
}
currentFile = internalFile
currentWriter = internalFile.fileWriter()
/**
* On some Android 11+ devices (especially Chinese OEMs), we observed that creating files
* using File(...) and createNewFile() can fail unexpectedly (background/doze modes/RAM cleaning/device cleanup utilities) with FileNotFoundException or EINVAL,
* even when writing to internal storage.
* This helper ensures safe creation of files by handling edge cases and logging issues to improve
* stability across all devices.
*/
if (!internalFile.exists()) {
try {
internalFile.createNewFile()

if (internalFile.canWrite()) {
currentFile = internalFile
currentWriter = internalFile.fileWriter()
}
} catch (e: Exception) {
Log.e("FileInit", "Failed to create or write to file: ${internalFile.absolutePath}", e)
return
}
}
}
}

Expand Down