Skip to content

Conversation

Stat1cV01D
Copy link
Contributor

Added a separate cross-platform library loader;
Added clang-format support;
Refactored hostfxr-related code into a dedicated class

@luttje
Copy link
Contributor

luttje commented Jun 25, 2021

It looks like you're still working on it so this may be obvious (in which case ignore it).

Since you're using a submodule to your dependency could you add submodules: 'true' under the actions/checkout workflow.

It looks like the workflow is failing to find your CMakeList because of it.

(I imagine the build would keep failing anyway since the current workflow file doesn't load submodules)

@Stat1cV01D
Copy link
Contributor Author

Since you're using a submodule to your dependency could you add submodules: 'true' under the actions/checkout workflow.

I haven't had a good chance to work with GitHub's CI, so thank you for the comment.

@luttje
Copy link
Contributor

luttje commented Jun 25, 2021

I'm also still figuring it out so good chance it isn't enough, though looking into the docs it seems that this is the way to fix it.

@Stat1cV01D Stat1cV01D force-pushed the cpp_refactoring branch 6 times, most recently from abffe52 to a688559 Compare June 25, 2021 14:38
@GlebChili GlebChili self-requested a review June 26, 2021 06:37
@GlebChili GlebChili added the pr-generate-docs-preview For labeled PRs, a live docs preview will be generated label Jul 13, 2021
@github-actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://ambitious-hill-0f19b7c03-103.westeurope.azurestaticapps.net

@GlebChili GlebChili removed the pr-generate-docs-preview For labeled PRs, a live docs preview will be generated label Jul 13, 2021
@Stat1cV01D Stat1cV01D closed this Mar 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants