-
Notifications
You must be signed in to change notification settings - Fork 9
deps: Update dependency com.google.errorprone:error_prone_core to v2.41.0 #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: Update dependency com.google.errorprone:error_prone_core to v2.41.0 #612
Conversation
|
Relevant: https://github.com/google/error-prone/releases/tag/v2.31.0 v2.31.0 was the last version that supports JDK 11. There might be a way to work around this, but it's low priority. We need to support Java 8 until Sept 2026. See https://cloud.google.com/java/docs/supported-java-versions. |
18cdeba to
e3b7a9f
Compare
e3b7a9f to
532b725
Compare
532b725 to
874f652
Compare
874f652 to
21d89fa
Compare
d88e47c to
fb03f12
Compare
eb73153 to
6c8dfb0
Compare
40ea12b to
f206b9c
Compare
581bcf3 to
02272e3
Compare
02272e3 to
26d1963
Compare
3f5bd2b to
c1fed16
Compare
…41.0 - Move errorprone to Java 17 and higher builds - Use new argument for stopping build on warning - Fix various problems identified by new errorprone version
c1fed16 to
2357ebe
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
| <id>java17</id> | ||
| <activation> | ||
| <jdk>[9,)</jdk> | ||
| <jdk>[17,)</jdk> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we go ahead and make the ErrorProne run only on 21 like we talked about maybe doing earlier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll send a follow-up CL to clean this up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've created #675 to do this and will experiment as time allows with various ways of cleaning up our pom file to surface ErrorProne warnings in a nice way.
This PR contains the following updates:
2.31.0->2.41.0Release Notes
google/error-prone (com.google.errorprone:error_prone_core)
v2.41.0: Error Prone 2.41.0Compare Source
New checks:
publicorprotectedmodifiers, but are effectively privateChanges:
Full changelog: google/error-prone@v2.40.0...v2.41.0
v2.40.0: Error Prone 2.40.0Compare Source
Changes:
Full changelog: google/error-prone@v2.39.0...v2.40.0
v2.39.0: Error Prone 2.39.0Compare Source
Changes:
Checks:
BooleanLiteral: PrefertruetoBoolean.TRUEExpensiveLenientFormatString: Renamed fromPreconditionsExpensiveString, detects unnecessary calls toString.formatin the arguments of lenient formatting methods.UnnecessaryQualifier: Detects@Qualifieror@BindingAnnotationannotations that have no effect, and can be removedIssues: #4996, #5045
Full changelog: google/error-prone@v2.38.0...v2.39.0
v2.38.0: Error Prone 2.38.0Compare Source
New checks:
AddNullMarkedToPackageInfo: adds@org.jspecify.annotations.NullMarkedannotation to package-info filesIntLiteralCast: Suggests a literal of the desired type instead of casting an int literal to a long, float, or doubleMisleadingEmptyVarargs: Discourages calling varargs methods that expect at least one argument with no arguments, like Mockito'sthenThrowPreconditionsExpensiveString: Discourages expensive string formatting in GuavaPreconditionschecksSelfSet: Detects mistakes likeproto.setFoo(proto.getFoo())UnnecessaryCopy: detect unnecessary copies of proto Lists and Maps.Closed issues: #4924, #4897, #4995
Full changelog: google/error-prone@v2.37.0...v2.38.0
v2.37.0: Error Prone 2.37.0Compare Source
Changes:
error_prone_type_annotationshave been been merged intoerror_prone_annotations.error_prone_type_annotationsis now deprecated, and will be removed in a future release.New checks:
AssignmentExpression- The use of an assignment expression can be surprising and hard to read; consider factoring out the assignment to a separate statement.IntFloatConversion- Detect calls toscalbthat should be using the double overload insteadInvalidSnippet- Detects snippets which omit the:required for inline code.JUnit4EmptyMethods- Detects empty JUnit4@Before,@After,@BeforeClass, and@AfterClassmethods.MockIllegalThrows- Detects cases where Mockito is configured to throw checked exception types which are impossible.NegativeBoolean- Prefer positive boolean names.RuleNotRun- DetectsTestRules not annotated with@Rule, that won't be run.StringConcatToTextBlock- Replaces concatenated multiline strings with text blocks.TimeInStaticInitializer- Detects accesses of the system time in static contexts.Closed issues:
@InlineMepatching ofStrings.repeatproduces broken code (#4819)_) variables (#4847)Full changelog: google/error-prone@v2.36.0...v2.37.0
v2.36.0: Error Prone 2.36.0Compare Source
Changes:
ErrorProneScannerfor AST nodes introduced after Java 11 (e5fd194)d67bc15)--should-stop=ifError=FLOWis set when using the-Xpluginintegration (e71db1f)New checks:
DuplicateBranches: Discourage conditional expressions and if statements where both branches are the sameRedundantControlFlow: Reports redundantcontinuestatements.Closed issues: #4633, #4646
Full changelog: google/error-prone@v2.35.1...v2.36.0
v2.35.1: Error Prone 2.35.1Compare Source
Error Prone's dependency on protobuf has been downgraded to 3.25.5 for this release.
Version 3.25.5 of protobuf still fixes CVE-2024-7254. This release is provided for users who aren't ready to update to 4.x, see also #4584 and #4634. Future versions of Error Prone will upgrade back to protobuf 4.x.
Full changelog: google/error-prone@v2.35.0...v2.35.1
v2.35.0: Error Prone 2.35.0Compare Source
Changes:
\sbefore the trailing delimiter inMisleadingEscapedSpaceTimeUnitMismatchimprovements: handle binary trees, consider trees likefooSeconds * 1000to have units of millisNew checks:
JavaDurationGetSecondsToToSeconds: Preferduration.toSeconds()overduration.getSeconds()Full changelog: google/error-prone@v2.34.0...v2.35.0
v2.34.0: Error Prone 2.34.0Compare Source
Changes:
--should-stop=ifError=FLOWis now required when running Error Prone (#4595)MemberNamecheck was renamed toIdentifierNameNew checks:
FutureTransformAsync: The usage of transformAsync is not necessary when all the return values of the transformation function are immediate futures.MisformattedTestData: Reformats Java source code inside Error Prone test cases.MisleadingEscapedSpace: Using\sanywhere except at the end of a line in a text block is potentially misleading.ThrowIfUncheckedKnownUnchecked:throwIfUnchecked(knownUnchecked)is equivalent tothrow knownUnchecked.Closed issues: #4595, #4598, #4620
Full changelog: google/error-prone@v2.33.0...v2.34.0
v2.33.0: Error Prone 2.33.0Compare Source
Similar to release 2.32.0, the minimum supported JDK version to run Error Prone is JDK 17 (#3803). Using Error Prone to compile code that is deployed to earlier versions is still fully supported, but will require using JDK 17 or newer for compilation and setting
--releaseor-source/-target/-bootclasspath.Changes:
New checks:
ArrayRecordComponent: Record components should not be arrays.Full changelog: google/error-prone@v2.32.0...v2.33.0
v2.32.0: Error Prone 2.32.0Compare Source
The minimum support JDK version to run Error Prone is now JDK 17 (#3803).
Using Error Prone to compile code that is deployed to earlier versions is still fully supported, but will requires using JDK 17 or newer for compilation and setting
--releaseor-source/-target/-bootclasspath.Full changelog: google/error-prone@v2.31.0...v2.32.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.