[wip] Pre commit #191
Closed
[wip] Pre commit #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this gist gives an idea how much maintenance the current repo would need to be compliant w/ the suggested pre-commit hooks. |
added 4 commits
November 19, 2020 11:04
# Conflicts: # tools/cloud_functions/README.md # tools/cloud_functions/gcs_event_based_ingest/gcs_ocn_bq_ingest/README.md # tools/cloud_functions/gcs_event_based_ingest/terraform_module/gcs_ocn_bq_ingest_function/README.md # tools/cloud_functions/gcs_event_based_ingest/terraform_module/gcs_ocn_bq_ingest_function/outputs.tf # tools/cloud_functions/gcs_event_based_ingest/terraform_module/gcs_ocn_bq_ingest_function/variables.tf
In the cloud funcitons module we had various python an terraform static analysis steps that were redundant with the repo wide pre-commit which will already be run by CI triggers. I've trimmed it to include only the tests specific to the cloud function and removed the duplicate static analysis configs in favor of the repo wide configs.
|
pushed a few commits to get my own stuff inline and not run redundant checks |
|
closed in favor of #192 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danieldeleo this PR introduces the pre-commit I'd suggest for this repo as we discussed.
It is work in progress as there is a lot of work to be done to get the existing code to comply to the standards imposed by the pre-commit.
As the repo maintiner you'll have to make decisions about whether to ignore existing directories temporarily with exclude or fix all the non-compliant code in this PR. You may also have more opinions about the various flake8 / hadolint / yamllint / pytest configurations / ignore codes.
R: @ryanmcdowell
CC: @potiuk @mik-laj who inspired most of this on an earlier pso project