Skip to content

Conversation

@Alex2357
Copy link

Background

Added ability to add imagePullSecrets for service accounts if requried to specify it

Testing Procedure

  • Test as tested before to check it worked without specifying imagePullSecrets
  • Create secret
    kubectl create secret generic $DOCKERCONFIG_SECRET_NAME
    --from-file=.dockerconfigjson=$XDG_RUNTIME_DIR/containers/auth.json
    --type=kubernetes.io/dockerconfigjson
    -n your-namespace

do helm install providing values like in this argo app

    helm:
      parameters:
      values: |
        serviceAccounts:
          imagePullSecrets:
          - name: secret-name

@Alex2357 Alex2357 requested review from a team and yoshi-approver as code owners August 20, 2025 10:05
@google-cla
Copy link

google-cla bot commented Aug 20, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant