Skip to content

fix(healthcare): set responseType to JSON instead of Buffer in getPatientEverything.js#4240

Open
angelcaamal wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-patient-everything
Open

fix(healthcare): set responseType to JSON instead of Buffer in getPatientEverything.js#4240
angelcaamal wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
angelcaamal:fix-fhir-patient-everything

Conversation

@angelcaamal
Copy link
Contributor

@angelcaamal angelcaamal commented Feb 27, 2026

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • Required CI tests pass (see CI testing)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

Note: Any check with (dev), (experimental), or (legacy) can be ignored and should not block your PR from merging (see CI testing).

@angelcaamal angelcaamal added the api: healthcare Issues related to the Cloud Healthcare API API. label Feb 27, 2026
@angelcaamal angelcaamal requested a review from a team as a code owner February 27, 2026 21:48
@angelcaamal angelcaamal added the samples Issues that are directly related to samples. label Feb 27, 2026
@angelcaamal angelcaamal requested review from a team as code owners February 27, 2026 21:48
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustness and usability of the getPatientEverything sample by ensuring proper JSON parsing of API responses and implementing comprehensive error handling. These changes prevent potential issues with data interpretation and provide clearer feedback in case of API failures, improving the overall reliability of the sample.

Highlights

  • API Client Configuration: The healthcare API client has been configured to explicitly set the responseType to 'json', ensuring that API responses are correctly parsed as JSON objects rather than raw buffers.
  • Error Handling Improvement: A try-catch block has been added around the PatientEverything API call to gracefully handle potential errors during the API request and provide informative error logging.
Changelog
  • healthcare/fhir/getPatientEverything.js
    • Configured the Google Cloud Healthcare API client to use 'json' as the response type.
    • Wrapped the PatientEverything API call in a try-catch block to handle and log errors.
Activity
  • The pull request was created by angelcaamal.
  • The PR description includes a standard checklist for contributions to the nodejs-docs-samples repository.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue by setting responseType to json to ensure the API response is parsed as JSON instead of a Buffer. It also improves robustness by adding a try...catch block for error handling. I've kept the suggestion to refine the logging to display the response data correctly.

Comment on lines +49 to 52
console.log(
`Got all resources in patient ${patientId} compartment:\n`,
JSON.stringify(patientEverything)
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

When responseType: 'json' is used, the patientEverything variable will contain the full API response object. The actual JSON payload from the response is located in the data property. To log only the relevant data, you should stringify patientEverything.data.

Using JSON.stringify(..., null, 2) will also pretty-print the JSON output, which improves readability in the console.

Suggested change
console.log(
`Got all resources in patient ${patientId} compartment:\n`,
JSON.stringify(patientEverything)
);
console.log(
`Got all resources in patient ${patientId} compartment:\n`,
JSON.stringify(patientEverything.data, null, 2)
);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: healthcare Issues related to the Cloud Healthcare API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant