Skip to content

Conversation

PFacheris
Copy link

Fixes #286. Not sure why these options aren't available in the job-exec module so just copied them over from the v2 module. Tested with a GCS volume and works perfectly.

@PFacheris PFacheris requested review from anamer, prabhu34, q2w and a team as code owners January 30, 2025 22:08
Copy link

google-cla bot commented Jan 30, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pataquets
Copy link

@PFacheris : Are you still interested/available to move this forward? Are you OK with sb else picking it up?

@PFacheris
Copy link
Author

@pataquets I'm fine with someone else picking it up though as far as I'm aware there's not really anything to be done at the moment. Just waiting on someone from the Google side to take a look and provide any feedback.

cc: @anamer @ayushmjain @prabhu34 or @q2w (since I see you listed as the code owners)

@PFacheris PFacheris requested a review from ayushmjain as a code owner May 27, 2025 18:31
@PFacheris PFacheris changed the title fix: support all volume options in job-exec module fix(job-exec): support all volume options in job-exec module Jun 6, 2025
@q2w
Copy link
Collaborator

q2w commented Jul 15, 2025

@PFacheris Could you run command for generating the documentation? https://codelabs.developers.google.com/cft-onboarding/#8

@PFacheris PFacheris reopened this Jul 28, 2025
@PFacheris
Copy link
Author

@PFacheris Could you run command for generating the documentation? https://codelabs.developers.google.com/cft-onboarding/#8

Apologies for the delay on this, done now! Let me know if there's anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

job-exec volumes tied to sql_instance only?
4 participants