feat(cloudrun-job): modify the vpc_access variable to allow direct subnet attachment as well as serverless connector #320
+28
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et attachment as well as connector
danielemuze
requested review from
a team,
anamer,
ayushmjain,
prabhu34 and
q2w
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…et attachment as well as connector
danielemuze
changed the title
danielemuze
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Added Support for Direct Subnet Attachment in vpc_access
Modified vpc_access to support both VPC Serverless Connector and Direct Subnet Attachment.
Added network and subnetwork options, allowing Cloud Run Jobs to receive IPs from a specific VPC subnet.
Ensured mutual exclusivity between connector and network/subnetwork to prevent conflicts.
Updated egress to support both PRIVATE_RANGES_ONLY and ALL_TRAFFIC for VPC Connectors.
Updated README.md to document these changes for users.
✅ Backwards compatible: Existing users relying on vpc_connector remain unaffected.
✅ New functionality: Users who need a private IP from a VPC subnet can now use this feature.