fix[sidecars]: Permit optional ports for sidecars so we can run sidecars #381
Conversation
atrull
requested review from
anamer,
ayushmjain,
prabhu34,
q2w and
a team
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
atrull
changed the title
There was a problem hiding this comment.
Thanks for the PR @atrull
Could an alternative be to explicitly specify ports = {} for the other containers?
| ports = optional(object({ | ||
| name = optional(string, "http1") | ||
| container_port = optional(number, 8080) | ||
| name = optional(string) | ||
| container_port = optional(number) | ||
| }), {}) |
There was a problem hiding this comment.
@q2w PTAL due to default change
There was a problem hiding this comment.
Could an alternative be to explicitly specify ports = {} for the other containers?
I believe ports = {} then just defaults back to "http1" and 8080, if the default values are kept in variables.tf.
I do not believe optional with a fallback value can be used in any solution of this issue. Any default/fallback values must be set by you re-implementing a fallback inside the main.tf, because this optional does not give you a mechanism to know if the user supplied any value or not; meaning it will always be http1 or a user-specified non-empty value, never empty.
This may close issue #302