feat(job-exec): add client variable support #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbtravi
requested review from
a team,
anamer,
ayushmjain,
prabhu34 and
q2w
as code owners
fbtravi
changed the title
bharathkkb
reviewed
Aug 23, 2025
There was a problem hiding this comment.
Thanks for the PR @fbtravi! Can you also update docs with make generate_docs
|
Hey @bharathkkb ! On macOS I hit an error running the Docker command (Go runtime crash with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add support for specifying an arbitrary API client identifier and version for google_cloud_run_v2_job resources.
Changes
Added client and client_version arguments to the google_cloud_run_v2_job resource in main.tf.
Introduced a new client variable (object) with optional name and version fields in variables.tf.
Updated default value for client to an empty object.
Why
This allows providing metadata for API client identification when creating or managing Cloud Run jobs, improving traceability and integration consistency.