-
Notifications
You must be signed in to change notification settings - Fork 133
feat(v2): add support for build_config arguments #398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(v2): add support for build_config arguments #398
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I believe this closes #397. |
Hello @trshafer |
/assign maemayve |
/gcbrun |
The change looks good to me but the description seems incorrect. The build_config block will not actually kick off a build. The only way to start a build is to use Cloud Run Functions. The build_config block was added to support dual edit between Cloud Run service resources and the Cloud Run Function that generated these services. More information about how the field is used is documented in the Cloud Run Functions Terraform Tutorial |
Hey @maemayve |
This PR adds support for the build_config block to the Cloud Run v2 module, enabling users to build container images from source using Cloud Build instead of pre-built container images.
✨ What's New
✅ New input variable: build_config — optional object block for Cloud Build configuration
✅ Dynamic block: Adds build_config block inside google_cloud_run_v2_service.main
✅ Output: Adds build_name output to expose Cloud Build job name (output-only)
✅ README update: Includes usage example for build_config