chore: Migrate simple_cloud_run kitchen -> cft #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnvans
commented
Sep 24, 2025
| deletion_policy = "DELETE" | ||
| name = "ci-cloud-run" | ||
| random_project_id = "true" | ||
| random_project_id_length = 8 |
There was a problem hiding this comment.
This is here to help with an "already exists" error I ran into while testing. Without this setting, we were using 16 bits for a "unique" name. After this setting, it will be 41 bits.
I did some calculations and if 50 projects are currently in use, there is a (roughly) 4% chance that there will be a naming clash among them. This gets reduced to a 1 in 10^10 chance with 41 bits.
I don't know whether the "already exists" error I saw was due to a collision, but using a longer project ID length will at least rule out this as a possible issue.
martijnvans
requested review from
anamer,
ayushmjain,
prabhu34,
q2w and
a team
as code owners
martijnvans
commented
Sep 24, 2025
| @@ -0,0 +1,48 @@ | |||
| // Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
This file was just copied from the simple_cloud_run_with_cmek test and lightly edited.
kminsu-google
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to unblock #402, which will be changing test setup to be multi-project. The kitchen framework does not understand how to deal with a multi-project test setup, so it has to be removed.