feat(go): upgrade delve to support go 1.25 #147
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @ktarplee, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces support for Go 1.25 by upgrading the Delve debugger and integrating the new Go version into the build and test infrastructure. It ensures that applications built with Go 1.25 can be properly debugged and tested within the existing system.
Highlights
- Go and Delve Version Upgrade: The go/helper-image/Dockerfile has been updated to use GOVERSION=1.25 and DELVE_VERSION=1.25.2, ensuring compatibility with the latest Go runtime.
- Skaffold Configuration Update: go/skaffold.yaml now includes a new build profile for go125app and references a new Kubernetes test manifest (test/k8s-test-go125.yaml) to enable testing with Go 1.25.
- New Kubernetes Test Manifest: A new file, go/test/k8s-test-go125.yaml, has been added. This manifest defines a Kubernetes Pod, Service, and Job to facilitate integration testing for Go 1.25 applications with Delve debugging support.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
I am not sure exactly how to test this yet. Since the debug image seems to not configurable in skaffold I think I will have to modify it and build skaffold from source. There might very well be a better way. |
There was a problem hiding this comment.
Code Review
This pull request updates the project to support Go 1.25 by upgrading the Go and Delve versions in the Dockerfile and adding corresponding build and test configurations in Skaffold. The changes are straightforward and follow the existing patterns in the codebase. I have one suggestion to improve the robustness of the new test manifest. Otherwise, the changes look good.
| initContainers: | ||
| - name: wait-for-go125 | ||
| image: kubectl | ||
| command: [sh, -c, "while ! curl -s hello-dlv-go125:8080 2>/dev/null; do echo waiting for app; sleep 1; done"] |
There was a problem hiding this comment.
The curl command in the initContainer can be made more robust. Currently, it doesn't check for HTTP-level errors (e.g., 5xx) and it prints the response body to the logs upon success. Using the -f (--fail) flag will cause curl to exit with an error on server errors, and redirecting stdout to /dev/null will keep the logs cleaner.
command: [sh, -c, "while ! curl -sf hello-dlv-go125:8080 >/dev/null 2>&1; do echo waiting for app; sleep 1; done"]
It looks like this can be tested in skaffold by setting the |
I was able to build and push the test image and then test with |
This PR is applying the obvious changes to support the latest version of Delve and therefore go 1.25.
Closes #146